Implement test and remove TODOs

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

cmd/discovery/client/client.go

@@ -82,8 +82,6 @@ func (c *Client) waitPass(p *block.Partition, attempts int) (pass string, err er
 }
 
 func (c *Client) getPass(server string, partition *block.Partition) (string, error) {
-	// TODO: This results in unexpected end of file when the other side closes the connection
-	// even when the passphrase is found. This shouldn't happen.
 	msg, err := tpm.Get(server,
 		tpm.WithAdditionalHeader("label", partition.Label),
 		tpm.WithAdditionalHeader("name", partition.Name),

pkg/challenger/challenger.go

@@ -180,8 +180,6 @@ func findSecretFor(requestData PassphraseRequestData, volumeList *keyserverv1alp
 	for _, v := range volumeList.Items {
 		if requestData.TPMHash == v.Spec.TPMHash {
 			for _, p := range v.Spec.Partitions {
-				// TODO: Test this change. It shouldn't match the volume if one of the fields in the request is empty
-				// and the volume has it empty too!
 				deviceNameMatches := requestData.DeviceName != "" && p.DeviceName == requestData.DeviceName
 				uuidMatches := requestData.UUID != "" && p.UUID == requestData.UUID
 				labelMatches := requestData.Label != "" && p.Label == requestData.Label

pkg/challenger/challenger_test.go

@@ -46,6 +46,32 @@ var _ = Describe("challenger", func() {
 			})
 		})
 
+		When("a sealedvolume with empty field exists", func() {
+			BeforeEach(func() {
+				volumeList = volumeListWithPartitionSpec(
+					keyserverv1alpha1.PartitionSpec{
+						Label:      "",
+						DeviceName: "not_matching",
+						UUID:       "not_matching",
+						Secret: &keyserverv1alpha1.SecretSpec{
+							Name: "the_secret",
+							Path: "the_path",
+						}})
+
+				requestData = PassphraseRequestData{
+					TPMHash:    "1234",
+					Label:      "",
+					DeviceName: "/dev/sda1",
+					UUID:       "sda1_uuid",
+				}
+			})
+
+			It("doesn't match a request with an empty field", func() {
+				volumeData := findSecretFor(requestData, volumeList)
+				Expect(volumeData).To(BeNil())
+			})
+		})
+
 		When("a sealedvolume matching the device name exists", func() {
 			BeforeEach(func() {
 				volumeList = volumeListWithPartitionSpec(