rancher/norman
1
0
Fork 0
mirror of https://github.com/rancher/norman.git synced 2025-09-13 05:42:37 +00:00
Code Issues Releases Wiki Activity

DNS label validation

Browse Source
This commit is contained in:
Alena Prokharchyk
2018-01-18 09:55:53 -08:00
committed by Darren Shepherd
parent c970c36427
commit 69d780d557
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
parse/builder/builder.go
View File

@@ -8,6 +8,7 @@ import (
"github.com/rancher/norman/types" "github.com/rancher/norman/types"
"github.com/rancher/norman/types/convert" "github.com/rancher/norman/types/convert"
"github.com/rancher/norman/types/definition" "github.com/rancher/norman/types/definition"
"k8s.io/apimachinery/pkg/util/validation"
) )
var ( var (
@@ -258,7 +259,14 @@ func (b *Builder) convert(fieldType string, value interface{}, op Operation) (in
case "string": case "string":
return convert.ToString(value), nil return convert.ToString(value), nil
case "dnsLabel": case "dnsLabel":
return convert.ToString(value), nil value := convert.ToString(value)
if op == Create || op == Update {
if errs := validation.IsDNS1123Subdomain(convert.ToString(value)); len(errs) != 0 {
return value, httperror.NewAPIError(httperror.InvalidFormat, fmt.Sprintf("invalid value %s: %s", value,
strings.Join(errs, ",")))
}
}
return value, nil
case "intOrString": case "intOrString":
num, err := convert.ToNumber(value) num, err := convert.ToNumber(value)
if err == nil { if err == nil {