From da40fa7b068e21ca85bfb3c9f4cf207f1008bf43 Mon Sep 17 00:00:00 2001 From: Darren Shepherd Date: Sat, 20 Jan 2018 23:23:24 -0700 Subject: [PATCH] don't validate empty string as DNS name --- parse/builder/builder.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/parse/builder/builder.go b/parse/builder/builder.go index 3d5070c8..841c339f 100644 --- a/parse/builder/builder.go +++ b/parse/builder/builder.go @@ -259,14 +259,17 @@ func (b *Builder) convert(fieldType string, value interface{}, op Operation) (in case "string": return convert.ToString(value), nil case "dnsLabel": - value := convert.ToString(value) + str := convert.ToString(value) + if str == "" { + return "", nil + } if op == Create || op == Update { - if errs := validation.IsDNS1123Subdomain(convert.ToString(value)); len(errs) != 0 { + if errs := validation.IsDNS1123Subdomain(str); len(errs) != 0 { return value, httperror.NewAPIError(httperror.InvalidFormat, fmt.Sprintf("invalid value %s: %s", value, strings.Join(errs, ","))) } } - return value, nil + return str, nil case "intOrString": num, err := convert.ToNumber(value) if err == nil {