From 8933f573f89248b1a956eae737c5f02838caf245 Mon Sep 17 00:00:00 2001 From: Darren Shepherd Date: Wed, 26 Aug 2020 21:25:00 -0700 Subject: [PATCH] Don't filter out nil objects --- controller/generic_controller.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/controller/generic_controller.go b/controller/generic_controller.go index 2c43a8e6..9057ea8e 100644 --- a/controller/generic_controller.go +++ b/controller/generic_controller.go @@ -73,12 +73,13 @@ func (g *genericController) AddHandler(ctx context.Context, name string, handler } func isNamespace(namespace string, obj runtime.Object) bool { - if namespace == "" { + if namespace == "" || obj == nil { return true } meta, err := meta.Accessor(obj) if err != nil { - return false + // if you can't figure out the namespace, just let it through + return true } return meta.GetNamespace() == namespace }