rancher/os
1
0
Fork 1
mirror of https://github.com/rancher/os.git synced 2025-06-24 14:01:34 +00:00
Code Issues Releases Wiki Activity

Use double-quoted string for writing proxy.sh

Browse Source 
Presence of special characters (i.e. &) in proxy environment values causes generation of an invalid /etc/profile.d/proxy.sh file.
This is a problem due to the common inclusion of special characters in passwords and proxy strings of the format htt[p|s]://user:pass@url:port.
This commit is contained in:
niusmallnan 2019-05-28 15:03:32 +08:00 committed by niusmallnan
parent 8d7f7199c9
commit 41b562c01f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/control/console_init.go
View File

@ -182,7 +182,7 @@ func consoleInitFunc() error {
proxyLines := []string{} proxyLines := []string{}
for _, k := range []string{"http_proxy", "HTTP_PROXY", "https_proxy", "HTTPS_PROXY", "no_proxy", "NO_PROXY"} { for _, k := range []string{"http_proxy", "HTTP_PROXY", "https_proxy", "HTTPS_PROXY", "no_proxy", "NO_PROXY"} {
if v, ok := cfg.Rancher.Environment[k]; ok { if v, ok := cfg.Rancher.Environment[k]; ok {
proxyLines = append(proxyLines, fmt.Sprintf("export %s=%s", k, v)) proxyLines = append(proxyLines, fmt.Sprintf("export %s=%q", k, v))
} }
} }