rancher/plugins
1
0
Fork 1
mirror of https://github.com/rancher/plugins.git synced 2025-09-18 03:57:40 +00:00
Code Issues Projects Releases Wiki Activity

Enable KeepAddrOnDown for ipv6 addresses

Browse Source 
This enables the keep_addr_on_down sysctl parameter for
IPV6 addresses configured via the ConfigureIface function.

This prevents IPAM confiuration to be lost when users need
to refresh the link state of an interface that has IPV6 addresses.

Signed-off-by: Marcelo Guerrero <marguerr@redhat.com>
This commit is contained in:
Marcelo Guerrero
2025-03-28 16:44:23 +01:00
committed by Casey Callendrello
parent b088cc3162
commit 062b3fceb4
2 changed files with 56 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/ipam/ipam_linux.go
View File

@@ -29,7 +29,8 @@ import (
const (
// Note: use slash as separator so we can have dots in interface name (VLANs)
DisableIPv6SysctlTemplate = "net/ipv6/conf/%s/disable_ipv6"
DisableIPv6SysctlTemplate = "net/ipv6/conf/%s/disable_ipv6"
KeepAddrOnDownSysctlTemplate = "net/ipv6/conf/%s/keep_addr_on_down"
)
// ConfigureIface takes the result of IPAM plugin and
@@ -56,8 +57,8 @@ func ConfigureIface(ifName string, res *current.Result) error {
return fmt.Errorf("failed to add IP addr %v to %q: invalid interface index", ipc, ifName)
}
// Make sure sysctl "disable_ipv6" is 0 if we are about to add
// an IPv6 address to the interface
// Make sure sysctl "disable_ipv6" is 0 and "keep_addr_on_down" is 1
// if we are about to add an IPv6 address to the interface
if !hasEnabledIpv6 && ipc.Address.IP.To4() == nil {
// Enabled IPv6 for loopback "lo" and the interface
// being configured
@@ -80,6 +81,15 @@ func ConfigureIface(ifName string, res *current.Result) error {
return fmt.Errorf("failed to enable IPv6 for interface %q (%s=%s): %v", iface, ipv6SysctlValueName, value, err)
}
}
// Enable "keep_addr_on_down" for the interface being configured
// This prevents the kernel from removing the address when the interface is brought down
keepAddrOnDownSysctlValueName := fmt.Sprintf(KeepAddrOnDownSysctlTemplate, ifName)
_, err = sysctl.Sysctl(keepAddrOnDownSysctlValueName, "1")
if err != nil {
return fmt.Errorf("failed to enable keep_addr_on_down for interface %q: %v", ifName, err)
}
hasEnabledIpv6 = true
}