From 9425d24c28579f065eb436d4d60fbac86a7a2891 Mon Sep 17 00:00:00 2001 From: Tomofumi Hayashi Date: Thu, 9 Aug 2018 22:28:12 +0900 Subject: [PATCH] Incorporate @jelloneck/@bboreham/@squeed's comments. --- plugins/meta/tuning/tuning.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/plugins/meta/tuning/tuning.go b/plugins/meta/tuning/tuning.go index beea39a2..156a4b73 100644 --- a/plugins/meta/tuning/tuning.go +++ b/plugins/meta/tuning/tuning.go @@ -164,12 +164,11 @@ func cmdAdd(args *skel.CmdArgs) error { } } - var err error - if tuningConf.Mac != "" { - if err = changeMacAddr(args.IfName, tuningConf.Mac); err == nil { - updateResultsMacAddr(*tuningConf, args.IfName, tuningConf.Mac) + if err = changeMacAddr(args.IfName, tuningConf.Mac); err != nil { + return err } + updateResultsMacAddr(*tuningConf, args.IfName, tuningConf.Mac) } if tuningConf.Promisc != false {