rancher/rke
1
0
Fork 0
mirror of https://github.com/rancher/rke.git synced 2025-09-05 08:50:13 +00:00
Code Issues Releases Wiki Activity

Remove n^2 algorithm. At 5000+ nodes plus this gets to be a real problem

Browse Source
This commit is contained in:
Darren Shepherd
2020-03-06 08:47:03 -07:00
parent eaf643e6a2
commit 1e34d2b464
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
cluster/validation.go
View File

@@ -198,18 +198,17 @@ func ValidateHostCount(c *Cluster) error {
} }
func validateDuplicateNodes(c *Cluster) error { func validateDuplicateNodes(c *Cluster) error {
addresses := make(map[string]struct{}, len(c.Nodes))
hostnames := make(map[string]struct{}, len(c.Nodes))
for i := range c.Nodes { for i := range c.Nodes {
for j := range c.Nodes { if _, ok := addresses[c.Nodes[i].Address]; ok {
if i == j { return fmt.Errorf("Cluster can't have duplicate node: %s", c.Nodes[i].Address)
continue
}
if c.Nodes[i].Address == c.Nodes[j].Address {
return fmt.Errorf("Cluster can't have duplicate node: %s", c.Nodes[i].Address)
}
if c.Nodes[i].HostnameOverride == c.Nodes[j].HostnameOverride {
return fmt.Errorf("Cluster can't have duplicate node: %s", c.Nodes[i].HostnameOverride)
}
} }
addresses[c.Nodes[i].Address] = struct{}{}
if _, ok := hostnames[c.Nodes[i].HostnameOverride]; ok {
return fmt.Errorf("Cluster can't have duplicate node: %s", c.Nodes[i].HostnameOverride)
}
hostnames[c.Nodes[i].HostnameOverride] = struct{}{}
} }
return nil return nil
} }