Merge pull request #2262 from ibrokethecloud/ecr-helper

ecr credential plugin

cluster/validation.go

@@ -54,6 +54,11 @@ func (c *Cluster) ValidateCluster(ctx context.Context) error {
 		return err
 	}
 
+	// validate registry credential plugin
+	if err := validateRegistryAuthPlugin(c); err != nil {
+		return err
+	}
+
 	// validate services options
 	return validateServicesOptions(c)
 }
@@ -630,3 +635,19 @@ func validateCRIDockerdOption(c *Cluster) error {
 	}
 	return nil
 }
+
+func validateRegistryAuthPlugin(c *Cluster) error {
+	for _, pr := range c.PrivateRegistriesMap {
+		if len(pr.CredentialPlugin) != 0 {
+			if credPluginType, ok := pr.CredentialPlugin["type"]; ok {
+				switch credPluginType {
+				case "ecr":
+					logrus.Debugf("Plugin type %s is valid", credPluginType)
+				default:
+					return fmt.Errorf("invalid registry plugin helper provided for %s", pr.URL)
+				}
+			}
+		}
+	}
+	return nil
+}