From d41abc7de4ae79b06b5c822422d85ff3d528a95d Mon Sep 17 00:00:00 2001
From: Yuki Nishiwaki <uckey.1067@gmail.com>
Date: Sun, 30 Jun 2019 23:56:33 +0900
Subject: [PATCH] NodeSelector should specify string explicitly

Kubernetes doesn't accept any other value but string in nodeSelector,
but if we specified ambiguous value like true, it's treated as a
non-string like bool and then failed to create resource because of type
mis-match, that's why we should make value of nodeSelector enclosed by
double quotations to ensure value is always string
---
 templates/coredns.go       | 2 +-
 templates/kubedns.go       | 2 +-
 templates/nginx-ingress.go | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/templates/coredns.go b/templates/coredns.go
index 357b37c1..c0323d8b 100644
--- a/templates/coredns.go
+++ b/templates/coredns.go
@@ -122,7 +122,7 @@ spec:
       nodeSelector:
         beta.kubernetes.io/os: linux
       {{ range $k, $v := .NodeSelector }}
-        {{ $k }}: {{ $v }}
+        {{ $k }}: "{{ $v }}"
       {{ end }}
       containers:
       - name: coredns
diff --git a/templates/kubedns.go b/templates/kubedns.go
index 63467eee..f03a1779 100644
--- a/templates/kubedns.go
+++ b/templates/kubedns.go
@@ -124,7 +124,7 @@ spec:
     spec:
       nodeSelector:
       {{ range $k, $v := .NodeSelector }}
-        {{ $k }}: {{ $v }}
+        {{ $k }}: "{{ $v }}"
       {{ end }}
       affinity:
         podAntiAffinity:
diff --git a/templates/nginx-ingress.go b/templates/nginx-ingress.go
index c6aa49c3..335238fc 100644
--- a/templates/nginx-ingress.go
+++ b/templates/nginx-ingress.go
@@ -188,7 +188,7 @@ spec:
       hostNetwork: true
       nodeSelector:
       {{ range $k, $v := .NodeSelector }}
-        {{ $k }}: {{ $v }}
+        {{ $k }}: "{{ $v }}"
       {{ end }}
       {{if eq .RBACConfig "rbac"}}
       serviceAccountName: nginx-ingress-serviceaccount