rancher/rke
1
0
Fork 0
mirror of https://github.com/rancher/rke.git synced 2025-07-14 15:46:03 +00:00
Code Issues Releases Wiki Activity

Merge pull request #3337 from manuelbuil/weaveDeprecation

Browse Source 
Add warning log about weave deprecation
This commit is contained in:
Manuel Buil 2023-09-19 14:57:20 +02:00 committed by GitHub
commit feca6a3048
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
cluster/validation.go
View File

@ -217,6 +217,13 @@ func validateNetworkOptions(c *Cluster) error {
if c.Network.Plugin == FlannelNetworkPlugin && c.Network.MTU != 0 { if c.Network.Plugin == FlannelNetworkPlugin && c.Network.MTU != 0 {
return fmt.Errorf("Network plugin [%s] does not support configuring MTU", FlannelNetworkPlugin) return fmt.Errorf("Network plugin [%s] does not support configuring MTU", FlannelNetworkPlugin)
} }
if c.Network.Plugin == WeaveNetworkPlugin {
if err := warnWeaveDeprecation(c.Version); err != nil {
return fmt.Errorf("Error while printing Weave deprecation message: %w", err)
}
}
dualStack := false dualStack := false
serviceClusterRanges := strings.Split(c.Services.KubeAPI.ServiceClusterIPRange, ",") serviceClusterRanges := strings.Split(c.Services.KubeAPI.ServiceClusterIPRange, ",")
if len(serviceClusterRanges) > 1 { if len(serviceClusterRanges) > 1 {
@ -731,3 +738,19 @@ func getClusterVersion(version string) (semver.Version, error) {
} }
return parsedVersion, nil return parsedVersion, nil
} }
// warnWeaveDeprecation prints a deprecation warning if version is higher than 1.27
func warnWeaveDeprecation(k8sVersion string) error {
version, err := util.StrToSemVer(k8sVersion)
if err != nil {
return fmt.Errorf("error while parsing cluster version [%s]: %w", k8sVersion, err)
}
version127, err := util.StrToSemVer("v1.27.0")
if err != nil {
return fmt.Errorf("failed to translate v1.27.0 to semver notation: %w", err)
}
if !version.LessThan(*version127) {
logrus.Warn("Weave CNI plugin is deprecated starting with Kubernetes v1.27 and will be removed in Kubernetes v1.30")
}
return nil
}