rancher/steve
1
0
Fork 0
mirror of https://github.com/rancher/steve.git synced 2025-09-13 13:59:40 +00:00
Code Issues Projects Releases Wiki Activity

Better gc (#717)

Browse Source 
* More error wrapping for SQL cache

* Use context.Context instead of stopCh

* Move CacheFor to Info log level

* Implement time-based GC

* Set default GC param when running standalone steve
This commit is contained in:
Tom Lebreux
2025-07-11 12:48:19 -04:00
committed by GitHub
parent 3692666375
commit 127d37391d
9 changed files with 170 additions and 195 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/sqlcache/db/client.go
View File

@@ -63,6 +63,13 @@ type Client interface {
//
// The transaction is committed if f returns nil, otherwise it is rolled back.
func (c *client) WithTransaction(ctx context.Context, forWriting bool, f WithTransactionFunction) error {
if err := c.withTransaction(ctx, forWriting, f); err != nil {
return fmt.Errorf("transaction: %w", err)
}
return nil
}
func (c *client) withTransaction(ctx context.Context, forWriting bool, f WithTransactionFunction) error {
c.connLock.RLock()
// note: this assumes _txlock=immediate in the connection string, see NewConnection
tx, err := c.conn.BeginTx(ctx, &sql.TxOptions{
@@ -70,7 +77,7 @@ func (c *client) WithTransaction(ctx context.Context, forWriting bool, f WithTra
})
c.connLock.RUnlock()
if err != nil {
return err
return fmt.Errorf("begin tx: %w", err)
}
if err = f(transaction.NewClient(tx)); err != nil {