From 7cff39371fbede456a74cceef56a1a4a2b3fd608 Mon Sep 17 00:00:00 2001 From: Eric Promislow Date: Mon, 8 Sep 2025 14:31:18 -0700 Subject: [PATCH] Add comments to clarify where non-test-mode methods are defined. (#809) --- pkg/sqlcache/informer/factory/informer_factory.go | 2 ++ pkg/sqlcache/informer/informer.go | 2 ++ 2 files changed, 4 insertions(+) diff --git a/pkg/sqlcache/informer/factory/informer_factory.go b/pkg/sqlcache/informer/factory/informer_factory.go index 97cdd065..8a43ccc7 100644 --- a/pkg/sqlcache/informer/factory/informer_factory.go +++ b/pkg/sqlcache/informer/factory/informer_factory.go @@ -153,6 +153,8 @@ func (f *CacheFactory) cacheForLocked(ctx context.Context, fields [][]string, ex _, encryptResourceAlways := defaultEncryptedResourceTypes[gvk] shouldEncrypt := f.encryptAll || encryptResourceAlways + // In non-test code this invokes pkg/sqlcache/informer/informer.go: NewInformer() + // search for "func NewInformer(ctx" i, err := f.newInformer(f.ctx, client, fields, externalUpdateInfo, selfUpdateInfo, transform, gvk, f.dbClient, shouldEncrypt, namespaced, watchable, f.gcInterval, f.gcKeepCount) if err != nil { return nil, err diff --git a/pkg/sqlcache/informer/informer.go b/pkg/sqlcache/informer/informer.go index 9b46bf1e..7dba8dcc 100644 --- a/pkg/sqlcache/informer/informer.go +++ b/pkg/sqlcache/informer/informer.go @@ -106,6 +106,8 @@ func NewInformer(ctx context.Context, client dynamic.ResourceInterface, fields [ // We therefore just disable it right away. resyncPeriod := time.Duration(0) + // In non-test mode `newInformer` is cache.NewSharedIndexInformer + // defined in k8s.io/client-go/tools/cache/shared_informer.go : func NewSharedIndexInformer(lw ... sii := newInformer(listWatcher, example, resyncPeriod, cache.Indexers{}) if transform != nil { if err := sii.SetTransform(transform); err != nil {