rancher/steve
1
0
Fork 0
mirror of https://github.com/rancher/steve.git synced 2025-08-11 03:01:38 +00:00
Code Issues Projects Releases Wiki Activity

Fix race in accessstore test (#466)

Browse Source
This commit is contained in:
Alejandro Ruiz 2025-01-29 02:35:24 +01:00 committed by GitHub
parent 5cdbd29ebe
commit 8ae74491e7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/accesscontrol/access_store_test.go
View File

@ -315,24 +315,27 @@ func TestAccessStore_AccessFor_concurrent(t *testing.T) {
const n = 5 // observation showed cases with up to 5 (or more) concurrent queries for the same user const n = 5 // observation showed cases with up to 5 (or more) concurrent queries for the same user
ids := make([]string, n)
wait := make(chan struct{}) wait := make(chan struct{})
var wg sync.WaitGroup var wg sync.WaitGroup
var id string for i := range n {
for range n {
wg.Add(1) wg.Add(1)
go func() { go func() {
<-wait <-wait
id = store.AccessFor(testUser).ID ids[i] = store.AccessFor(testUser).ID
wg.Done() wg.Done()
}() }()
} }
close(wait) close(wait)
wg.Wait() wg.Wait()
if got, want := len(slices.Compact(ids)), 1; got != want {
t.Errorf("Unexpected number of ids: got %d, want %d", got, want)
}
if got, want := len(asCache.setCalls), 1; got != want { if got, want := len(asCache.setCalls), 1; got != want {
t.Errorf("Unexpected number of cache entries: got %d, want %d", got, want) t.Errorf("Unexpected number of cache entries: got %d, want %d", got, want)
} }
if got, want := asCache.setCalls[id], 1; got != want { if got, want := asCache.setCalls[ids[0]], 1; got != want {
t.Errorf("Unexpected number of calls to cache.Set(): got %d, want %d", got, want) t.Errorf("Unexpected number of calls to cache.Set(): got %d, want %d", got, want)
} }
} }