From 971e2b7f3d90bbd90ecb25ebee1d90b73eb87fad Mon Sep 17 00:00:00 2001
From: "Felipe C. Gehrke" <felipe.gehrke@suse.com>
Date: Tue, 12 Nov 2024 12:40:57 -0300
Subject: [PATCH] fixing apistatus type casting assert

---
 pkg/ext/delegate_error_test.go | 36 ++++++++++++----------------------
 1 file changed, 12 insertions(+), 24 deletions(-)

diff --git a/pkg/ext/delegate_error_test.go b/pkg/ext/delegate_error_test.go
index 6c5c08d6..234b2d59 100644
--- a/pkg/ext/delegate_error_test.go
+++ b/pkg/ext/delegate_error_test.go
@@ -143,10 +143,8 @@ func TestDelegateError_Watch(t *testing.T) {
 			assert.Error(t, err)
 
 			// check if error is an api error
-			if _, ok := err.(apierrors.APIStatus); ok {
-				assert.True(t, ok)
-				return
-			}
+			_, ok := err.(apierrors.APIStatus)
+			assert.True(t, ok)
 		} else {
 			assert.NoError(t, err)
 			assert.Equal(t, watch, tt.expected.watch)
@@ -508,10 +506,8 @@ func TestDelegateError_Update(t *testing.T) {
 				assert.Error(t, err)
 
 				// check if error is an apierror
-				if _, ok := err.(apierrors.APIStatus); ok {
-					assert.True(t, ok)
-					return
-				}
+				_, ok := err.(apierrors.APIStatus)
+				assert.True(t, ok)
 			} else {
 				assert.NoError(t, err)
 				assert.Equal(t, tt.expect.obj, obj)
@@ -662,10 +658,8 @@ func TestDelegateError_Create(t *testing.T) {
 				assert.Error(t, err)
 
 				// check if error is an apierror
-				if _, ok := err.(apierrors.APIStatus); ok {
-					assert.True(t, ok)
-					return
-				}
+				_, ok := err.(apierrors.APIStatus)
+				assert.True(t, ok)
 			} else {
 				assert.NoError(t, err)
 				assert.Equal(t, tt.expect.createResult, result)
@@ -824,10 +818,8 @@ func TestDelegateError_Delete(t *testing.T) {
 				assert.Error(t, err)
 
 				// check if error is an apierror
-				if _, ok := err.(apierrors.APIStatus); ok {
-					assert.True(t, ok)
-					return
-				}
+				_, ok := err.(apierrors.APIStatus)
+				assert.True(t, ok)
 			} else {
 				assert.NoError(t, err)
 				assert.Equal(t, tt.expect.deleteResult, result)
@@ -941,10 +933,8 @@ func TestDelegateError_Get(t *testing.T) {
 				assert.Error(t, err)
 
 				// check if error is an apierror
-				if _, ok := err.(apierrors.APIStatus); ok {
-					assert.True(t, ok)
-					return
-				}
+				_, ok := err.(apierrors.APIStatus)
+				assert.True(t, ok)
 			} else {
 				assert.NoError(t, err)
 				assert.Equal(t, tt.expect.getResult, result)
@@ -1075,10 +1065,8 @@ func TestDelegateError_List(t *testing.T) {
 				assert.Error(t, err)
 
 				// check if error is an apierror
-				if _, ok := err.(apierrors.APIStatus); ok {
-					assert.True(t, ok)
-					return
-				}
+				_, ok := err.(apierrors.APIStatus)
+				assert.True(t, ok)
 			} else {
 				assert.NoError(t, err)
 				assert.Equal(t, tt.expect.listResult, result)