mirror of
https://github.com/rancher/steve.git
synced 2025-09-08 18:59:58 +00:00
SQLite backed cache: Support sorting mgmt clusters on value in a specific condition (#447)
* Replace primary/secondary sort fields with an array of sort directives. * Allow more than 2 sort-params in a search query. * Add a virtual 'status.ready' field to clusters. * Rename status.ready -> status.connected * Set virtual field 'spec.internal' <- spec.displayName == 'local' * Need to declare all virtual fields to index. * Ready clusters have condition[type==Ready && status=True] * Update the README to reflect generalized sorting. * Bump lasso to get revised sort directives. * Review-driven changes, mostly comments and drop unneeded code. * Add unit tests to verify sort-order stringification. * Ignore empty-string sort components. * Fix a rebase mishap. * Drop unneeded commented-out code. * Clusters have a 'spec.internal' field, no need to synthesize one. * Added a note on square-brackets for label references. This should be added to the README for filter queries in the PR for 46333. * Bump to latest sqlcache-free lasso
This commit is contained in:
Eric Promislow
GitHub
297
pkg/resources/virtual/clusters/clusters_test.go
Normal file
297
pkg/resources/virtual/clusters/clusters_test.go
Normal file
@@ -0,0 +1,297 @@
|
||||
package clusters
|
||||
|
||||
import (
|
||||
"reflect"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/require"
|
||||
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
|
||||
)
|
||||
|
||||
func TestTransformManagedCluster(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
input *unstructured.Unstructured
|
||||
wantOutput *unstructured.Unstructured
|
||||
wantError bool
|
||||
}{
|
||||
{
|
||||
name: "a non-ready cluster",
|
||||
input: &unstructured.Unstructured{
|
||||
Object: map[string]interface{}{
|
||||
"id": 1,
|
||||
"type": "management.cattle.io.cluster",
|
||||
"metadata": map[string]interface{}{
|
||||
"name": "c-m-boris",
|
||||
},
|
||||
"spec": map[string]interface{}{
|
||||
"displayName": "boris",
|
||||
"internal": false,
|
||||
},
|
||||
"status": map[string]interface{}{
|
||||
"conditions": []interface{}{
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:52:16Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "BackingNamespaceCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:52:16Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "DefaultProjectCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:52:16Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "SystemProjectCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:52:17Z",
|
||||
"status": "False",
|
||||
"transitioning": false,
|
||||
"type": "Ready",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
wantOutput: &unstructured.Unstructured{
|
||||
Object: map[string]interface{}{
|
||||
"id": 1,
|
||||
"type": "management.cattle.io.cluster",
|
||||
"metadata": map[string]interface{}{
|
||||
"name": "c-m-boris",
|
||||
},
|
||||
"spec": map[string]interface{}{
|
||||
"displayName": "boris",
|
||||
"internal": false,
|
||||
},
|
||||
"status": map[string]interface{}{
|
||||
"conditions": []interface{}{
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:52:16Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "BackingNamespaceCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:52:16Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "DefaultProjectCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:52:16Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "SystemProjectCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:52:17Z",
|
||||
"status": "False",
|
||||
"transitioning": false,
|
||||
"type": "Ready",
|
||||
},
|
||||
},
|
||||
"connected": false,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "the local cluster",
|
||||
input: &unstructured.Unstructured{
|
||||
Object: map[string]interface{}{
|
||||
"id": 2,
|
||||
"type": "management.cattle.io.cluster",
|
||||
"metadata": map[string]interface{}{
|
||||
"name": "local",
|
||||
},
|
||||
"spec": map[string]interface{}{
|
||||
"displayName": "local",
|
||||
"internal": true,
|
||||
},
|
||||
"status": map[string]interface{}{
|
||||
"conditions": []interface{}{
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:41:37Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "BackingNamespaceCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:41:37Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "DefaultProjectCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "Ready",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
wantOutput: &unstructured.Unstructured{
|
||||
Object: map[string]interface{}{
|
||||
"id": 2,
|
||||
"type": "management.cattle.io.cluster",
|
||||
"metadata": map[string]interface{}{
|
||||
"name": "local",
|
||||
},
|
||||
"spec": map[string]interface{}{
|
||||
"displayName": "local",
|
||||
"internal": true,
|
||||
},
|
||||
"status": map[string]interface{}{
|
||||
"conditions": []interface{}{
|
||||
map[string]interface{}{
|
||||
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:41:37Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "BackingNamespaceCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:41:37Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "DefaultProjectCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "Ready",
|
||||
},
|
||||
},
|
||||
"connected": true,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "a ready non-local cluster",
|
||||
input: &unstructured.Unstructured{
|
||||
Object: map[string]interface{}{
|
||||
"id": 3,
|
||||
"type": "management.cattle.io.cluster",
|
||||
"metadata": map[string]interface{}{
|
||||
"name": "c-m-natasha",
|
||||
},
|
||||
"spec": map[string]interface{}{
|
||||
"displayName": "c-m-natasha",
|
||||
"internal": false,
|
||||
},
|
||||
"status": map[string]interface{}{
|
||||
"conditions": []interface{}{
|
||||
map[string]interface{}{
|
||||
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:41:37Z",
|
||||
"status": "Ready",
|
||||
"transitioning": false,
|
||||
"type": "BackingNamespaceCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:41:37Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "DefaultProjectCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "Ready",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
wantOutput: &unstructured.Unstructured{
|
||||
Object: map[string]interface{}{
|
||||
"id": 3,
|
||||
"type": "management.cattle.io.cluster",
|
||||
"metadata": map[string]interface{}{
|
||||
"name": "c-m-natasha",
|
||||
},
|
||||
"spec": map[string]interface{}{
|
||||
"displayName": "c-m-natasha",
|
||||
"internal": false,
|
||||
},
|
||||
"status": map[string]interface{}{
|
||||
"conditions": []interface{}{
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:41:37Z",
|
||||
"status": "Ready",
|
||||
"transitioning": false,
|
||||
"type": "BackingNamespaceCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
|
||||
"error": false,
|
||||
"lastUpdateTime": "2025-01-10T22:41:37Z",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "DefaultProjectCreated",
|
||||
},
|
||||
map[string]interface{}{
|
||||
"error": false,
|
||||
"lastUpdateTime": "",
|
||||
"status": "True",
|
||||
"transitioning": false,
|
||||
"type": "Ready",
|
||||
},
|
||||
},
|
||||
"connected": true,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
got, err := TransformManagedCluster(tt.input)
|
||||
if tt.wantError {
|
||||
require.Error(t, err)
|
||||
} else {
|
||||
require.NoError(t, err)
|
||||
require.Equal(t, tt.wantOutput, got)
|
||||
}
|
||||
if (err != nil) != tt.wantError {
|
||||
t.Errorf("TransformManagedCluster() error = %v, wantErr %v", err, tt.wantError)
|
||||
return
|
||||
}
|
||||
if !reflect.DeepEqual(got, tt.wantOutput) {
|
||||
t.Errorf("TransformManagedCluster() got = %v, want %v", got, tt.wantOutput)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user