1
0
mirror of https://github.com/rancher/steve.git synced 2025-09-12 04:39:05 +00:00

Fix CRD Created At field (#723)

* Add Tokens and Kubeconfig fields to date mapping

* Fix missing cols in transform func for watch

* Mark CRDs as.. CRD

* Don't transform CRD's date field
This commit is contained in:
Tom Lebreux
2025-07-11 13:28:52 -04:00
committed by GitHub
parent 127d37391d
commit faa5ad63e9
11 changed files with 116 additions and 24 deletions

View File

@@ -25,6 +25,7 @@ func TestTransformChain(t *testing.T) {
hasSummary *summary.SummarizedObject
hasRelationships []summarycache.Relationship
columns []rescommon.ColumnDefinition
isCRD bool
wantOutput any
wantError bool
}{
@@ -130,6 +131,7 @@ func TestTransformChain(t *testing.T) {
"id": "old-id",
},
},
isCRD: true,
columns: []rescommon.ColumnDefinition{
{
Field: "metadata.fields[0]",
@@ -224,6 +226,69 @@ func TestTransformChain(t *testing.T) {
},
},
},
{
name: "built-in type metadata.fields has a date field - should NOT convert to timestamp",
hasSummary: &summary.SummarizedObject{
PartialObjectMetadata: v1.PartialObjectMetadata{
ObjectMeta: v1.ObjectMeta{
Name: "testobj",
Namespace: "test-ns",
},
TypeMeta: v1.TypeMeta{
APIVersion: "apiextensions.k8s.io/v1",
Kind: "CustomResourceDefinition",
},
},
Summary: summary.Summary{
State: "success",
Transitioning: false,
Error: false,
},
},
input: &unstructured.Unstructured{
Object: map[string]interface{}{
"apiVersion": "apiextensions.k8s.io/v1",
"kind": "CustomResourceDefinition",
"metadata": map[string]interface{}{
"name": "testobj",
"namespace": "test-ns",
"fields": []interface{}{"2025-07-03T18:54:57Z"},
},
"id": "old-id",
},
},
columns: []rescommon.ColumnDefinition{
{
TableColumnDefinition: v1.TableColumnDefinition{
Name: "Created At",
Type: "date",
},
Field: "metadata.fields[0]",
},
},
wantOutput: &unstructured.Unstructured{
Object: map[string]interface{}{
"apiVersion": "apiextensions.k8s.io/v1",
"kind": "CustomResourceDefinition",
"metadata": map[string]interface{}{
"name": "testobj",
"namespace": "test-ns",
"relationships": []any(nil),
"state": map[string]interface{}{
"name": "success",
"error": false,
"transitioning": false,
"message": "",
},
"fields": []interface{}{
"2025-07-03T18:54:57Z",
},
},
"id": "test-ns/testobj",
"_id": "old-id",
},
},
},
{
name: "processable event",
input: &unstructured.Unstructured{
@@ -497,7 +562,7 @@ func TestTransformChain(t *testing.T) {
if test.name == "a non-ready cluster" {
fmt.Printf("Stop here")
}
output, err := tb.GetTransformFunc(gvk, test.columns)(test.input)
output, err := tb.GetTransformFunc(gvk, test.columns, test.isCRD)(test.input)
require.Equal(t, test.wantOutput, output)
if test.wantError {
require.Error(t, err)