1
0
mirror of https://github.com/rancher/steve.git synced 2025-07-14 23:31:11 +00:00
steve/pkg/stores/sqlproxy
Eric Promislow 57ce685118
Sort-indirect PR broken into smaller parts: part 3/6 - pass listOptions by reference (#612)
* Move types related to list options and sql queries into their own package.

The problem having these in the informer package is that eventually code
in other packages will need to import `informer` only for constants or types,
but some members of the informer package may already depend on those. Best to
move type definitions into their own simpler package.

* Fix the ListOptions sort field.

Instead of making it a single array-ish field, convert it into a
true array of Sort Directives.  Easier to read, less bending backwards.

* Pass the listOptions struct by reference to avoid copying.

We never update the ListOptions struct once it's created so there's
no need to pass it by value.

This might be a near-useless optimization...
2025-04-25 11:19:34 -07:00
..
tablelistconvert Migrate the mocking library to uber's (#291) 2024-10-10 10:28:25 -07:00
dynamic_mocks_test.go Migrate the mocking library to uber's (#291) 2024-10-10 10:28:25 -07:00
proxy_mocks_test.go Sort-indirect PR broken into smaller parts: part 3/6 - pass listOptions by reference (#612) 2025-04-25 11:19:34 -07:00
proxy_store_test.go Sort-indirect PR broken into smaller parts: part 3/6 - pass listOptions by reference (#612) 2025-04-25 11:19:34 -07:00
proxy_store.go Sort-indirect PR broken into smaller parts: part 3/6 - pass listOptions by reference (#612) 2025-04-25 11:19:34 -07:00
sql_informer_mocks_test.go Sort-indirect PR broken into smaller parts: part 3/6 - pass listOptions by reference (#612) 2025-04-25 11:19:34 -07:00