github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-08-12 05:22:33 +00:00
Code Issues Projects Releases Wiki Activity

tools: acrnctl: fix possibility of buffer overflow

Browse Source 
Replace strcpy with strncpy to avoid possibility of buffer overflow

Signed-off-by: Kaige Fu <kaige.fu@intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
This commit is contained in:
Kaige Fu 2018-05-28 11:53:09 +08:00 committed by lijinxia
parent 004d2e2696
commit 11abe6e81e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/acrn-manager/acrnctl.c
View File

@ -45,6 +45,7 @@
#include "monitor_msg.h" #include "monitor_msg.h"
#define ACRNCTL_OPT_ROOT "/opt/acrn/conf" #define ACRNCTL_OPT_ROOT "/opt/acrn/conf"
#define MAX_NAME_LEN (128)
/* helper functions */ /* helper functions */
static int shell_cmd(const char *cmd, char *outbuf, int len) static int shell_cmd(const char *cmd, char *outbuf, int len)
@ -88,7 +89,7 @@ static void process_msg(struct vmm_msg *msg)
#define ACRN_DM_SOCK_ROOT "/run/acrn" #define ACRN_DM_SOCK_ROOT "/run/acrn"
struct vmm_struct { struct vmm_struct {
char name[128]; char name[MAX_NAME_LEN];
unsigned long state; unsigned long state;
LIST_ENTRY(vmm_struct) list; LIST_ENTRY(vmm_struct) list;
}; };
@ -121,7 +122,7 @@ static struct vmm_struct *vmm_list_add(char *name)
return NULL; return NULL;
} }
strcpy(s->name, name); strncpy(s->name, name, MAX_NAME_LEN - 1);
LIST_INSERT_HEAD(&vmm_head, s, list); LIST_INSERT_HEAD(&vmm_head, s, list);
return s; return s;