github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-08-18 08:11:07 +00:00
Code Issues Projects Releases Wiki Activity

hv: vlapic: local APIC ID related code cleaning up

Browse Source 
From SDM Vol3 10.4.6:
Some processors permit software to modify the APIC ID. However, the
ability of software to modify the APIC ID is processor model specific.
Because of this, operating system software should avoid writing to the
local APIC ID register.

So to permit change APIC ID is not one *must* feature. Keep it simple,
we are also reject to modify it.

This patch does code cleaning up for LAPIC ID related emulation.

Signed-off-by: Yu Wang <yu1.wang@intel.com>
Acked-by: Anthony Xu <anthony.xu@intel.com>
This commit is contained in:
Yu Wang 2018-08-22 14:24:17 +00:00 committed by lijinxia
parent c43d0e4f01
commit 74ff712085
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
hypervisor/arch/x86/guest/vlapic.c
View File

@ -216,16 +216,10 @@ vlapic_ldr_write_handler(struct acrn_vlapic *vlapic)
}
static void
vlapic_id_write_handler(struct acrn_vlapic *vlapic)
vlapic_id_write_handler(__unused struct acrn_vlapic *vlapic)
{
struct lapic_regs *lapic;
/*
* We don't allow the ID register to be modified so reset it back to
* its default value.
*/
lapic = &(vlapic->apic_page);
lapic->id = vlapic_get_id(vlapic);
/* Force APIC ID as readonly */
return;
}
static inline uint32_t
@ -1479,7 +1473,6 @@ vlapic_write(struct acrn_vlapic *vlapic, uint32_t offset,
retval = 0;
switch (offset) {
case APIC_OFFSET_ID:
lapic->id = data32;
vlapic_id_write_handler(vlapic);
break;
case APIC_OFFSET_TPR: