hv: move panic out of hypercall

Just return the errno to the caller.

Signed-off-by: Li, Fei1 <fei1.li@intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>

hypervisor/common/hypercall.c

@@ -381,21 +381,26 @@ static void complete_request(struct vcpu *vcpu)
 
 int64_t hcall_notify_req_finish(uint64_t vmid, uint64_t vcpu_id)
 {
-	int64_t ret = 0;
 	union vhm_request_buffer *req_buf;
 	struct vhm_request *req;
 	struct vcpu *vcpu;
 	struct vm *target_vm = get_vm_from_vmid(vmid);
 
 	/* make sure we have set req_buf */
-	if (!target_vm || target_vm->sw.io_shared_page == NULL)
+	if (!target_vm || target_vm->sw.io_shared_page == NULL) {
+		pr_err("%s, invalid parameter\n", __func__);
 		return -EINVAL;
+	}
 
 	dev_dbg(ACRN_DBG_HYCALL, "[%d] NOTIFY_FINISH for vcpu %d",
 			vmid, vcpu_id);
 
 	vcpu = vcpu_from_vid(target_vm, vcpu_id);
-	ASSERT(vcpu != NULL, "Failed to get VCPU context.");
+	if (vcpu == NULL) {
+		pr_err("%s, failed to get VCPU %d context from VM %d\n",
+			__func__, vcpu_id, target_vm->attr.id);
+		return -EINVAL;
+	}
 
 	req_buf = (union vhm_request_buffer *)target_vm->sw.io_shared_page;
 	req = req_buf->req_queue + vcpu_id;
@@ -405,7 +410,7 @@ int64_t hcall_notify_req_finish(uint64_t vmid, uint64_t vcpu_id)
 		 (req->processed == REQ_STATE_FAILED)))
 		complete_request(vcpu);
 
-	return ret;
+	return 0;
 }
 
 int64_t _set_vm_memmap(struct vm *vm, struct vm *target_vm,
@@ -597,26 +602,34 @@ int64_t hcall_gpa_to_hpa(struct vm *vm, uint64_t vmid, uint64_t param)
 
 int64_t hcall_assign_ptdev(struct vm *vm, uint64_t vmid, uint64_t param)
 {
-	int64_t ret = 0;
+	int64_t ret;
 	uint16_t bdf;
 	struct vm *target_vm = get_vm_from_vmid(vmid);
 
-	if (target_vm == NULL)
-		return -1;
+	if (target_vm == NULL) {
+		pr_err("%s, vm is null\n", __func__);
+		return -EINVAL;
+	}
 
 	if (copy_from_vm(vm, &bdf, param, sizeof(bdf))) {
-		pr_err("%s: Unable copy param to vm\n", __func__);
-		return -1;
+		pr_err("%s: Unable copy param from vm %d\n",
+			__func__, vm->attr.id);
+		return -EIO;
 	}
 
 	/* create a iommu domain for target VM if not created */
 	if (!target_vm->iommu_domain) {
-		ASSERT(target_vm->arch_vm.nworld_eptp, "EPT of VM not set!");
+		if (target_vm->arch_vm.nworld_eptp == 0) {
+			pr_err("%s, EPT of VM not set!\n",
+				__func__, target_vm->attr.id);
+			return -EPERM;
+		}
 		/* TODO: how to get vm's address width? */
 		target_vm->iommu_domain = create_iommu_domain(vmid,
 				target_vm->arch_vm.nworld_eptp, 48);
-		ASSERT(target_vm->iommu_domain,
-				"failed to created iommu domain!");
+		if (target_vm->iommu_domain == NULL)
+			return -ENODEV;
+
 	}
 	ret = assign_iommu_device(target_vm->iommu_domain,
 			(uint8_t)(bdf >> 8), (uint8_t)(bdf & 0xff));

hypervisor/common/trusty_hypercall.c

@@ -35,19 +35,22 @@ int64_t hcall_world_switch(struct vcpu *vcpu)
 {
 	int next_world_id = !(vcpu->arch_vcpu.cur_context);
 
+	if (next_world_id >= NR_WORLD) {
+		pr_err("%s world_id %d exceed max number of Worlds\n",
+			__func__, next_world_id);
+		return -EINVAL;
+	}
+
 	if (!vcpu->vm->sworld_control.sworld_enabled) {
-		pr_err("Secure World is not enabled!\n");
-		return -1;
+		pr_err("%s, Secure World is not enabled!\n", __func__);
+		return -EPERM;
 	}
 
 	if (!vcpu->vm->arch_vm.sworld_eptp) {
-		pr_err("Trusty is not initialized!\n");
-		return -1;
+		pr_err("%s, Trusty is not initialized!\n", __func__);
+		return -EPERM;
 	}
 
-	ASSERT(next_world_id < NR_WORLD,
-		"world_id exceed max number of Worlds");
-
 	switch_world(vcpu, next_world_id);
 	return 0;
 }
@@ -55,22 +58,23 @@ int64_t hcall_world_switch(struct vcpu *vcpu)
 int64_t hcall_initialize_trusty(struct vcpu *vcpu, uint64_t param)
 {
 	if (!vcpu->vm->sworld_control.sworld_enabled) {
-		pr_err("Secure World is not enabled!\n");
-		return -1;
+		pr_err("%s, Secure World is not enabled!\n", __func__);
+		return -EPERM;
 	}
 
 	if (vcpu->vm->arch_vm.sworld_eptp) {
-		pr_err("Trusty already initialized!\n");
-		return -1;
+		pr_err("%s, Trusty already initialized!\n", __func__);
+		return -EPERM;
 	}
 
-	ASSERT(vcpu->arch_vcpu.cur_context == NORMAL_WORLD,
-		"The Trusty Initialize hypercall must be from Normal World");
-
-	if (!initialize_trusty(vcpu, param)) {
-		pr_err("Failed to initialize trusty!\n");
-		return -1;
+	if (vcpu->arch_vcpu.cur_context != NORMAL_WORLD) {
+		pr_err("%s, must initialize Trusty from Normal World!\n",
+			__func__);
+		return -EPERM;
 	}
 
+	if (!initialize_trusty(vcpu, param))
+		return -ENODEV;
+
 	return 0;
 }