github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-21 13:08:42 +00:00
Code Issues Projects Releases Wiki Activity

hv:fix return value violation in vmexit handler

Browse Source 
Check return value for the called functions in vmexit handler

Signed-off-by: Mingqiang Chi <mingqiang.chi@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Mingqiang Chi 2018-07-10 13:33:33 +08:00 committed by lijinxia
parent 2686fe76bc
commit f01e6efdf5
4 changed files with 24 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
hypervisor/arch/x86/guest/vlapic.c
View File

@ -2258,7 +2258,7 @@ apicv_inject_pir(struct vlapic *vlapic)
int apic_access_vmexit_handler(struct vcpu *vcpu) int apic_access_vmexit_handler(struct vcpu *vcpu)
{ {
int access_type, offset = 0, ret; int access_type, offset = 0, err = 0;
uint64_t qual; uint64_t qual;
struct vlapic *vlapic; struct vlapic *vlapic;
@ -2271,23 +2271,25 @@ int apic_access_vmexit_handler(struct vcpu *vcpu)
vlapic = vcpu->arch_vcpu.vlapic; vlapic = vcpu->arch_vcpu.vlapic;
ret = decode_instruction(vcpu); err = decode_instruction(vcpu);
/* apic access should already fetched instruction, decode_instruction /* apic access should already fetched instruction, decode_instruction
* will not trigger #PF, so if it failed, just return error_no * will not trigger #PF, so if it failed, just return error_no
*/ */
if (ret < 0) if (err < 0)
return ret; return err;
if (access_type == 1) { if (access_type == 1) {
if (emulate_instruction(vcpu) == 0) if (emulate_instruction(vcpu) == 0)
vlapic_write(vlapic, 1, offset, vcpu->mmio.value); err = vlapic_write(vlapic, 1, offset, vcpu->mmio.value);
} else if (access_type == 0) { } else if (access_type == 0) {
vlapic_read(vlapic, 1, offset, &vcpu->mmio.value); err = vlapic_read(vlapic, 1, offset, &vcpu->mmio.value);
emulate_instruction(vcpu); if (err < 0)
return err;
err = emulate_instruction(vcpu);
} }
TRACE_2L(TRACE_VMEXIT_APICV_ACCESS, qual, (uint64_t)vlapic); TRACE_2L(TRACE_VMEXIT_APICV_ACCESS, qual, (uint64_t)vlapic);
return 0; return err;
} }
int veoi_vmexit_handler(struct vcpu *vcpu) int veoi_vmexit_handler(struct vcpu *vcpu)

16
hypervisor/arch/x86/guest/vmsr.c
View File

@ -140,6 +140,7 @@ void init_msr_emulation(struct vcpu *vcpu)
int rdmsr_vmexit_handler(struct vcpu *vcpu) int rdmsr_vmexit_handler(struct vcpu *vcpu)
{ {
int err = 0;
uint32_t msr; uint32_t msr;
uint64_t v = 0UL; uint64_t v = 0UL;
int cur_context = vcpu->arch_vcpu.cur_context; int cur_context = vcpu->arch_vcpu.cur_context;
@ -151,7 +152,7 @@ int rdmsr_vmexit_handler(struct vcpu *vcpu)
switch (msr) { switch (msr) {
case MSR_IA32_TSC_DEADLINE: case MSR_IA32_TSC_DEADLINE:
{ {
vlapic_rdmsr(vcpu, msr, &v); err = vlapic_rdmsr(vcpu, msr, &v);
break; break;
} }
case MSR_IA32_TIME_STAMP_COUNTER: case MSR_IA32_TIME_STAMP_COUNTER:
@ -221,7 +222,7 @@ int rdmsr_vmexit_handler(struct vcpu *vcpu)
case MSR_IA32_APIC_BASE: case MSR_IA32_APIC_BASE:
{ {
/* Read APIC base */ /* Read APIC base */
vlapic_rdmsr(vcpu, msr, &v); err = vlapic_rdmsr(vcpu, msr, &v);
break; break;
} }
default: default:
@ -245,11 +246,12 @@ int rdmsr_vmexit_handler(struct vcpu *vcpu)
TRACE_2L(TRACE_VMEXIT_RDMSR, msr, v); TRACE_2L(TRACE_VMEXIT_RDMSR, msr, v);
return 0; return err;
} }
int wrmsr_vmexit_handler(struct vcpu *vcpu) int wrmsr_vmexit_handler(struct vcpu *vcpu)
{ {
int err = 0;
uint32_t msr; uint32_t msr;
uint64_t v; uint64_t v;
struct run_context *cur_context = struct run_context *cur_context =
@ -266,7 +268,7 @@ int wrmsr_vmexit_handler(struct vcpu *vcpu)
switch (msr) { switch (msr) {
case MSR_IA32_TSC_DEADLINE: case MSR_IA32_TSC_DEADLINE:
{ {
vlapic_wrmsr(vcpu, msr, v); err = vlapic_wrmsr(vcpu, msr, v);
break; break;
} }
case MSR_IA32_TIME_STAMP_COUNTER: case MSR_IA32_TIME_STAMP_COUNTER:
@ -340,7 +342,7 @@ int wrmsr_vmexit_handler(struct vcpu *vcpu)
} }
case MSR_IA32_PAT: case MSR_IA32_PAT:
{ {
vmx_wrmsr_pat(vcpu, v); err = vmx_wrmsr_pat(vcpu, v);
break; break;
} }
case MSR_IA32_GS_BASE: case MSR_IA32_GS_BASE:
@ -355,7 +357,7 @@ int wrmsr_vmexit_handler(struct vcpu *vcpu)
} }
case MSR_IA32_APIC_BASE: case MSR_IA32_APIC_BASE:
{ {
vlapic_wrmsr(vcpu, msr, v); err = vlapic_wrmsr(vcpu, msr, v);
break; break;
} }
default: default:
@ -373,5 +375,5 @@ int wrmsr_vmexit_handler(struct vcpu *vcpu)
TRACE_2L(TRACE_VMEXIT_WRMSR, msr, v); TRACE_2L(TRACE_VMEXIT_WRMSR, msr, v);
return 0; return err;
} }

2
hypervisor/arch/x86/virq.c
View File

@ -525,7 +525,7 @@ int exception_vmexit_handler(struct vcpu *vcpu)
/* Handle all other exceptions */ /* Handle all other exceptions */
vcpu_retain_rip(vcpu); vcpu_retain_rip(vcpu);
vcpu_queue_exception(vcpu, exception_vector, int_err_code); status = vcpu_queue_exception(vcpu, exception_vector, int_err_code);
if (exception_vector == IDT_MC) { if (exception_vector == IDT_MC) {
/* just print error message for #MC, it then will be injected /* just print error message for #MC, it then will be injected

7
hypervisor/arch/x86/vmexit.c
View File

@ -236,6 +236,7 @@ int cpuid_vmexit_handler(struct vcpu *vcpu)
int cr_access_vmexit_handler(struct vcpu *vcpu) int cr_access_vmexit_handler(struct vcpu *vcpu)
{ {
int err = 0;
uint64_t *regptr; uint64_t *regptr;
struct run_context *cur_context = struct run_context *cur_context =
&vcpu->arch_vcpu.contexts[vcpu->arch_vcpu.cur_context]; &vcpu->arch_vcpu.contexts[vcpu->arch_vcpu.cur_context];
@ -267,11 +268,11 @@ int cr_access_vmexit_handler(struct vcpu *vcpu)
VM_EXIT_CR_ACCESS_CR_NUM(vcpu->arch_vcpu.exit_qualification)) { VM_EXIT_CR_ACCESS_CR_NUM(vcpu->arch_vcpu.exit_qualification)) {
case 0x00U: case 0x00U:
/* mov to cr0 */ /* mov to cr0 */
vmx_write_cr0(vcpu, *regptr); err = vmx_write_cr0(vcpu, *regptr);
break; break;
case 0x04U: case 0x04U:
/* mov to cr4 */ /* mov to cr4 */
vmx_write_cr4(vcpu, *regptr); err = vmx_write_cr4(vcpu, *regptr);
break; break;
case 0x08U: case 0x08U:
/* mov to cr8 */ /* mov to cr8 */
@ -292,7 +293,7 @@ int cr_access_vmexit_handler(struct vcpu *vcpu)
VM_EXIT_CR_ACCESS_CR_NUM VM_EXIT_CR_ACCESS_CR_NUM
(vcpu->arch_vcpu.exit_qualification)); (vcpu->arch_vcpu.exit_qualification));
return 0; return err;
} }
/* /*