Compare commits

..

17 Commits

Author SHA1 Message Date
Kubernetes Publisher
08ba23b07b Fix Godeps.json to point to kubernetes-1.11.7 tags 2019-01-26 16:17:03 +00:00
Kubernetes Publisher
4022682532 Merge pull request #72839 from liggitt/automated-cherry-pick-of-#72825-upstream-release-1.11
Automated cherry pick of #72825: Find current resourceVersion for waiting for

Kubernetes-commit: 0bc3747c9bb458bc4495547d4a24452702efcd6b
2019-01-17 15:34:10 -08:00
Jordan Liggitt
0a8c852f46 Find current resourceVersion for waiting for deletion/conditions
Kubernetes-commit: b980266971c60df921cf311fa4d4a5b7ba07ae1a
2019-01-11 10:38:18 -05:00
Kubernetes Publisher
573fc71f7a Merge pull request #71325 from cheftako/automated-cherry-pick-of-#71285-upstream-release-1.11
Automated cherry pick of #71285 upstream release 1.11

Kubernetes-commit: 2921f9a19ce3ac9b55d5231ae2deb2bf2f5706e4
2018-12-04 04:01:58 +00:00
Kubernetes Publisher
81f05ccbec Merge pull request #70765 from wenjiaswe/automated-cherry-pick-of-#70663-upstream-release-1.11
Automated cherry pick of #70663: update  godeps for golang.org/x/net/... to

Kubernetes-commit: d95e84d3ac09c12a3800e29a90c6c687adf97ea5
2018-12-04 00:04:43 +00:00
Walter Fender
02c3db7e5d Report KCM as unhealthy if leader election is wedged. Feedback from lavalamp and deads2k. Changed Check() logic to be central to LeaderElector. Further changes, especially cleaning up the test code.
Kubernetes-commit: 746f343fcc467656cb8ac08e0d6447f5ecffff66
2018-11-12 18:45:21 -08:00
Wenjia Zhang
d43910c7ed update staging godeps for golang.org/x/net/... to release-branch.go1.10
Kubernetes-commit: 7234d6621898c8544ba53bb612fa9acd0db41514
2018-11-06 15:49:50 -08:00
Kubernetes Publisher
56e7a63b5e Merge pull request #68842 from wenjiaswe/automated-cherry-pick-of-#68530-upstream-release-1.11
Automated cherry pick of #68530: Rewrite finalURLTemplate used only for metrics of dynamic client

Kubernetes-commit: 011647662b54bd2904ca6eeae59c0e9b5aca83d3
2018-10-10 04:57:04 +00:00
Kubernetes Publisher
02543cdbce Merge pull request #68552 from the-redback/automated-cherry-pick-of-#66078-upstream-release-1.11
Automated cherry pick of #66078: fix dynamic client listing bug

Kubernetes-commit: 9b517e008b9604951f68c859b1d26d5e1a896597
2018-10-04 11:02:59 +00:00
Wenjia Zhang
014054a6d3 Rewrite finalURLTemplate used only for metrics because of dynamic client change
Kubernetes-commit: 2f25fd01640f37d206112da48ff8c3faf4e17275
2018-09-14 11:31:21 -07:00
Kubernetes Publisher
f2f85107ca Merge pull request #67164 from dekkagaijin/automated-cherry-pick-of-#65799-upstream-release-1.11
Automatic merge from submit-queue.

Automated cherry pick of #65799: Escape illegal characters in remote extra keys

Cherry pick of #65799 on release-1.11.

#65799: Escape illegal characters in remote extra keys

```release-note
action required: the API server and client-go libraries have been fixed to support additional non-alpha-numeric characters in UserInfo "extra" data keys. Both should be updated in order to properly support extra data containing "/" characters or other characters disallowed in HTTP headers.
```

Kubernetes-commit: f53fc73da201d21cb12f6093a68f01b5ef594e5c
2018-08-21 07:40:22 +00:00
Kubernetes Publisher
60fd738f89 Merge pull request #67240 from nikhita/automated-cherry-pick-of-#66249-upstream-release-1.11
Automatic merge from submit-queue.

Automated cherry pick of #66249: fill in normal restmapping info with the legacy guess

Fixes 1.11 part of https://github.com/kubernetes/kubernetes/issues/67235

Cherry pick of #66249 on release-1.11.

#66249: fill in normal restmapping info with the legacy guess

```release-note
Fix creation of custom resources when the CRD contains non-conventional pluralization and subresources
```

Kubernetes-commit: 10ecc6db83fd47a93eb0940e2e4434f2b0a5c3ec
2018-08-15 03:28:43 -07:00
Kubernetes Publisher
1f13a808da Merge pull request #66683 from awly/automated-cherry-pick-of-#66395-upstream-release-1.11
Automatic merge from submit-queue.

Automated cherry pick of #66395: Set connrotation dialer via restclient.Config.Dialer

Cherry pick of #66395 on release-1.11.

#66395: Set connrotation dialer via restclient.Config.Dialer

Kubernetes-commit: 77555257773c21d18a2eafa3c532b28973970d3b
2018-08-06 13:40:42 +00:00
Andrew Lytvynov
401c87eddd Set connrotation dialer via restclient.Config.Dialer
Instead of Transport. This fixes ExecPlugin, which fails if
restclient.Config.Transport is set.

Kubernetes-commit: 89322ec5deb057483b3c91816aac48fe7044ecd8
2018-07-25 16:22:32 -07:00
David Eads
897ec2f639 fill in normal restmapping info with the legacy guess
Kubernetes-commit: 4d6d243503535ea290530d5548ac657b1529986f
2018-07-16 13:38:43 -04:00
David Eads
f7a93c0e74 fix dynamic client listing bug
updated bazel

Kubernetes-commit: 1f1711d311188dccd8c5bd6984b01445d8a61f53
2018-07-11 13:05:54 -04:00
Jake Sanders
e07adc6e69 Escape illegal characters in remote extra keys
Signed-off-by: Jake Sanders <jsand@google.com>

Kubernetes-commit: 1db56879e5386ea8baee0f658eed40bc7658b24d
2018-07-03 21:19:15 -07:00
13 changed files with 899 additions and 144 deletions

174
Godeps/Godeps.json generated
View File

@@ -1,6 +1,6 @@
{
"ImportPath": "k8s.io/client-go",
"GoVersion": "go1.9",
"GoVersion": "go1.10",
"GodepVersion": "v80",
"Packages": [
"./..."
@@ -188,27 +188,27 @@
},
{
"ImportPath": "golang.org/x/net/context",
"Rev": "1c05540f6879653db88113bc4a2b70aec4bd491f"
"Rev": "0ed95abb35c445290478a5348a7b38bb154135fd"
},
{
"ImportPath": "golang.org/x/net/context/ctxhttp",
"Rev": "1c05540f6879653db88113bc4a2b70aec4bd491f"
"Rev": "0ed95abb35c445290478a5348a7b38bb154135fd"
},
{
"ImportPath": "golang.org/x/net/http2",
"Rev": "1c05540f6879653db88113bc4a2b70aec4bd491f"
"Rev": "0ed95abb35c445290478a5348a7b38bb154135fd"
},
{
"ImportPath": "golang.org/x/net/http2/hpack",
"Rev": "1c05540f6879653db88113bc4a2b70aec4bd491f"
"Rev": "0ed95abb35c445290478a5348a7b38bb154135fd"
},
{
"ImportPath": "golang.org/x/net/idna",
"Rev": "1c05540f6879653db88113bc4a2b70aec4bd491f"
"Rev": "0ed95abb35c445290478a5348a7b38bb154135fd"
},
{
"ImportPath": "golang.org/x/net/lex/httplex",
"Rev": "1c05540f6879653db88113bc4a2b70aec4bd491f"
"Rev": "0ed95abb35c445290478a5348a7b38bb154135fd"
},
{
"ImportPath": "golang.org/x/oauth2",
@@ -268,323 +268,323 @@
},
{
"ImportPath": "k8s.io/api/admissionregistration/v1alpha1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/admissionregistration/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/apps/v1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/apps/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/apps/v1beta2",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/authentication/v1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/authentication/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/authorization/v1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/authorization/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/autoscaling/v1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/autoscaling/v2beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/batch/v1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/batch/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/batch/v2alpha1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/certificates/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/core/v1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/events/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/extensions/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/imagepolicy/v1alpha1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/networking/v1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/policy/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/rbac/v1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/rbac/v1alpha1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/rbac/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/scheduling/v1alpha1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/scheduling/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/settings/v1alpha1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/storage/v1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/storage/v1alpha1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/api/storage/v1beta1",
"Rev": "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"
"Rev": "e86510ea3fe79b17eda7b8b3bb5cf8811d3af968"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/api/equality",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/api/errors",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/api/meta",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/api/resource",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/api/testing",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/api/testing/fuzzer",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/api/testing/roundtrip",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/apis/meta/fuzzer",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/apis/meta/internalversion",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/apis/meta/v1",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/apis/meta/v1beta1",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/conversion",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/conversion/queryparams",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/fields",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/labels",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/runtime",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/runtime/schema",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/runtime/serializer",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/runtime/serializer/json",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/runtime/serializer/protobuf",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/runtime/serializer/recognizer",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/runtime/serializer/streaming",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/runtime/serializer/versioning",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/selection",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/types",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/cache",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/clock",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/diff",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/errors",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/framer",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/httpstream",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/httpstream/spdy",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/intstr",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/json",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/mergepatch",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/net",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/remotecommand",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/runtime",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/sets",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/strategicpatch",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/validation",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/validation/field",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/wait",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/util/yaml",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/version",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/pkg/watch",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/third_party/forked/golang/json",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/third_party/forked/golang/netutil",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/apimachinery/third_party/forked/golang/reflect",
"Rev": "103fd098999dc9c0c88536f5c9ad2e5da39373ae"
"Rev": "1525e4dadd2df06debdeb27ee24ac7db5b6413b1"
},
{
"ImportPath": "k8s.io/kube-openapi/pkg/util/proto",

View File

@@ -33,6 +33,10 @@ import (
)
func NewSimpleDynamicClient(scheme *runtime.Scheme, objects ...runtime.Object) *FakeDynamicClient {
// In order to use List with this client, you have to have the v1.List registered in your scheme. Neat thing though
// it does NOT have to be the *same* list
scheme.AddKnownTypeWithName(schema.GroupVersionKind{Group: "fake-dynamic-client-group", Version: "v1", Kind: "List"}, &unstructured.UnstructuredList{})
codecs := serializer.NewCodecFactory(scheme)
o := testing.NewObjectTracker(scheme, codecs.UniversalDecoder())
for _, obj := range objects {
@@ -272,11 +276,11 @@ func (c *dynamicResourceClient) List(opts metav1.ListOptions) (*unstructured.Uns
switch {
case len(c.namespace) == 0:
obj, err = c.client.Fake.
Invokes(testing.NewRootListAction(c.resource, schema.GroupVersionKind{Version: "v1", Kind: "List"}, opts), &metav1.Status{Status: "dynamic list fail"})
Invokes(testing.NewRootListAction(c.resource, schema.GroupVersionKind{Group: "fake-dynamic-client-group", Version: "v1", Kind: "" /*List is appended by the tracker automatically*/}, opts), &metav1.Status{Status: "dynamic list fail"})
case len(c.namespace) > 0:
obj, err = c.client.Fake.
Invokes(testing.NewListAction(c.resource, schema.GroupVersionKind{Version: "v1", Kind: "List"}, c.namespace, opts), &metav1.Status{Status: "dynamic list fail"})
Invokes(testing.NewListAction(c.resource, schema.GroupVersionKind{Group: "fake-dynamic-client-group", Version: "v1", Kind: "" /*List is appended by the tracker automatically*/}, c.namespace, opts), &metav1.Status{Status: "dynamic list fail"})
}
@@ -299,13 +303,15 @@ func (c *dynamicResourceClient) List(opts metav1.ListOptions) (*unstructured.Uns
}
list := &unstructured.UnstructuredList{}
for _, item := range entireList.Items {
list.SetResourceVersion(entireList.GetResourceVersion())
for i := range entireList.Items {
item := &entireList.Items[i]
metadata, err := meta.Accessor(item)
if err != nil {
return nil, err
}
if label.Matches(labels.Set(metadata.GetLabels())) {
list.Items = append(list.Items, item)
list.Items = append(list.Items, *item)
}
}
return list, nil

View File

@@ -0,0 +1,66 @@
/*
Copyright 2018 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package fake
import (
"testing"
"k8s.io/apimachinery/pkg/api/equality"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/util/diff"
)
func newUnstructured(apiVersion, kind, namespace, name string) *unstructured.Unstructured {
return &unstructured.Unstructured{
Object: map[string]interface{}{
"apiVersion": apiVersion,
"kind": kind,
"metadata": map[string]interface{}{
"namespace": namespace,
"name": name,
},
},
}
}
func TestList(t *testing.T) {
scheme := runtime.NewScheme()
client := NewSimpleDynamicClient(scheme,
newUnstructured("group/version", "TheKind", "ns-foo", "name-foo"),
newUnstructured("group2/version", "TheKind", "ns-foo", "name2-foo"),
newUnstructured("group/version", "TheKind", "ns-foo", "name-bar"),
newUnstructured("group/version", "TheKind", "ns-foo", "name-baz"),
newUnstructured("group2/version", "TheKind", "ns-foo", "name2-baz"),
)
listFirst, err := client.Resource(schema.GroupVersionResource{Group: "group", Version: "version", Resource: "thekinds"}).List(metav1.ListOptions{})
if err != nil {
t.Fatal(err)
}
expected := []unstructured.Unstructured{
*newUnstructured("group/version", "TheKind", "ns-foo", "name-foo"),
*newUnstructured("group/version", "TheKind", "ns-foo", "name-bar"),
*newUnstructured("group/version", "TheKind", "ns-foo", "name-baz"),
}
if !equality.Semantic.DeepEqual(listFirst.Items, expected) {
t.Fatal(diff.ObjectGoPrintDiff(expected, listFirst.Items))
}
}

View File

@@ -20,6 +20,7 @@ import (
"bytes"
"context"
"crypto/tls"
"errors"
"fmt"
"io"
"net"
@@ -178,21 +179,10 @@ func (a *Authenticator) UpdateTransportConfig(c *transport.Config) error {
return &roundTripper{a, rt}
}
getCert := c.TLS.GetCert
c.TLS.GetCert = func() (*tls.Certificate, error) {
// If previous GetCert is present and returns a valid non-nil
// certificate, use that. Otherwise use cert from exec plugin.
if getCert != nil {
cert, err := getCert()
if err != nil {
return nil, err
}
if cert != nil {
return cert, nil
}
}
return a.cert()
if c.TLS.GetCert != nil {
return errors.New("can't add TLS certificate callback: transport.Config.TLS.GetCert already set")
}
c.TLS.GetCert = a.cert
var dial func(ctx context.Context, network, addr string) (net.Conn, error)
if c.Dial != nil {

View File

@@ -455,17 +455,9 @@ func (r *Request) URL() *url.URL {
// finalURLTemplate is similar to URL(), but will make all specific parameter values equal
// - instead of name or namespace, "{name}" and "{namespace}" will be used, and all query
// parameters will be reset. This creates a copy of the request so as not to change the
// underlying object. This means some useful request info (like the types of field
// selectors in use) will be lost.
// TODO: preserve field selector keys
// parameters will be reset. This creates a copy of the url so as not to change the
// underlying object.
func (r Request) finalURLTemplate() url.URL {
if len(r.resourceName) != 0 {
r.resourceName = "{name}"
}
if r.namespaceSet && len(r.namespace) != 0 {
r.namespace = "{namespace}"
}
newParams := url.Values{}
v := []string{"{value}"}
for k := range r.params {
@@ -473,6 +465,59 @@ func (r Request) finalURLTemplate() url.URL {
}
r.params = newParams
url := r.URL()
segments := strings.Split(r.URL().Path, "/")
groupIndex := 0
index := 0
if r.URL() != nil && r.baseURL != nil && strings.Contains(r.URL().Path, r.baseURL.Path) {
groupIndex += len(strings.Split(r.baseURL.Path, "/"))
}
if groupIndex >= len(segments) {
return *url
}
const CoreGroupPrefix = "api"
const NamedGroupPrefix = "apis"
isCoreGroup := segments[groupIndex] == CoreGroupPrefix
isNamedGroup := segments[groupIndex] == NamedGroupPrefix
if isCoreGroup {
// checking the case of core group with /api/v1/... format
index = groupIndex + 2
} else if isNamedGroup {
// checking the case of named group with /apis/apps/v1/... format
index = groupIndex + 3
} else {
// this should not happen that the only two possibilities are /api... and /apis..., just want to put an
// outlet here in case more API groups are added in future if ever possible:
// https://kubernetes.io/docs/concepts/overview/kubernetes-api/#api-groups
// if a wrong API groups name is encountered, return the {prefix} for url.Path
url.Path = "/{prefix}"
url.RawQuery = ""
return *url
}
//switch segLength := len(segments) - index; segLength {
switch {
// case len(segments) - index == 1:
// resource (with no name) do nothing
case len(segments)-index == 2:
// /$RESOURCE/$NAME: replace $NAME with {name}
segments[index+1] = "{name}"
case len(segments)-index == 3:
if segments[index+2] == "finalize" || segments[index+2] == "status" {
// /$RESOURCE/$NAME/$SUBRESOURCE: replace $NAME with {name}
segments[index+1] = "{name}"
} else {
// /namespace/$NAMESPACE/$RESOURCE: replace $NAMESPACE with {namespace}
segments[index+1] = "{namespace}"
}
case len(segments)-index >= 4:
segments[index+1] = "{namespace}"
// /namespace/$NAMESPACE/$RESOURCE/$NAME: replace $NAMESPACE with {namespace}, $NAME with {name}
if segments[index+3] != "finalize" && segments[index+3] != "status" {
// /$RESOURCE/$NAME/$SUBRESOURCE: replace $NAME with {name}
segments[index+3] = "{name}"
}
}
url.Path = path.Join(segments...)
return *url
}

View File

@@ -340,21 +340,169 @@ func TestResultIntoWithNoBodyReturnsErr(t *testing.T) {
}
func TestURLTemplate(t *testing.T) {
uri, _ := url.Parse("http://localhost")
r := NewRequest(nil, "POST", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0)
r.Prefix("pre1").Resource("r1").Namespace("ns").Name("nm").Param("p0", "v0")
full := r.URL()
if full.String() != "http://localhost/pre1/namespaces/ns/r1/nm?p0=v0" {
t.Errorf("unexpected initial URL: %s", full)
uri, _ := url.Parse("http://localhost/some/base/url/path")
testCases := []struct {
Request *Request
ExpectedFullURL string
ExpectedFinalURL string
}{
{
// non dynamic client
Request: NewRequest(nil, "POST", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("api", "v1").Resource("r1").Namespace("ns").Name("nm").Param("p0", "v0"),
ExpectedFullURL: "http://localhost/some/base/url/path/api/v1/namespaces/ns/r1/nm?p0=v0",
ExpectedFinalURL: "http://localhost/some/base/url/path/api/v1/namespaces/%7Bnamespace%7D/r1/%7Bname%7D?p0=%7Bvalue%7D",
},
{
// non dynamic client with wrong api group
Request: NewRequest(nil, "POST", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("pre1", "v1").Resource("r1").Namespace("ns").Name("nm").Param("p0", "v0"),
ExpectedFullURL: "http://localhost/some/base/url/path/pre1/v1/namespaces/ns/r1/nm?p0=v0",
ExpectedFinalURL: "http://localhost/%7Bprefix%7D",
},
{
// dynamic client with core group + namespace + resourceResource (with name)
// /api/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/api/v1/namespaces/ns/r1/name1"),
ExpectedFullURL: "http://localhost/some/base/url/path/api/v1/namespaces/ns/r1/name1",
ExpectedFinalURL: "http://localhost/some/base/url/path/api/v1/namespaces/%7Bnamespace%7D/r1/%7Bname%7D",
},
{
// dynamic client with named group + namespace + resourceResource (with name)
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/g1/v1/namespaces/ns/r1/name1"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/g1/v1/namespaces/ns/r1/name1",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/g1/v1/namespaces/%7Bnamespace%7D/r1/%7Bname%7D",
},
{
// dynamic client with core group + namespace + resourceResource (with NO name)
// /api/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/api/v1/namespaces/ns/r1"),
ExpectedFullURL: "http://localhost/some/base/url/path/api/v1/namespaces/ns/r1",
ExpectedFinalURL: "http://localhost/some/base/url/path/api/v1/namespaces/%7Bnamespace%7D/r1",
},
{
// dynamic client with named group + namespace + resourceResource (with NO name)
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/g1/v1/namespaces/ns/r1"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/g1/v1/namespaces/ns/r1",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/g1/v1/namespaces/%7Bnamespace%7D/r1",
},
{
// dynamic client with core group + resourceResource (with name)
// /api/$RESOURCEVERSION/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/api/v1/r1/name1"),
ExpectedFullURL: "http://localhost/some/base/url/path/api/v1/r1/name1",
ExpectedFinalURL: "http://localhost/some/base/url/path/api/v1/r1/%7Bname%7D",
},
{
// dynamic client with named group + resourceResource (with name)
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/g1/v1/r1/name1"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/g1/v1/r1/name1",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/g1/v1/r1/%7Bname%7D",
},
{
// dynamic client with named group + namespace + resourceResource (with name) + subresource
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%NAME/$SUBRESOURCE
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/namespaces/namespaces/namespaces/namespaces/namespaces/namespaces/finalize"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/namespaces/namespaces/namespaces/finalize",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/%7Bnamespace%7D/namespaces/%7Bname%7D/finalize",
},
{
// dynamic client with named group + namespace + resourceResource (with name)
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/namespaces/namespaces/namespaces/namespaces/namespaces/namespaces"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/namespaces/namespaces/namespaces",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/%7Bnamespace%7D/namespaces/%7Bname%7D",
},
{
// dynamic client with named group + namespace + resourceResource (with NO name) + subresource
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%SUBRESOURCE
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/namespaces/namespaces/namespaces/namespaces/namespaces/finalize"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/namespaces/namespaces/finalize",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/%7Bnamespace%7D/namespaces/finalize",
},
{
// dynamic client with named group + namespace + resourceResource (with NO name) + subresource
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%SUBRESOURCE
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/namespaces/namespaces/namespaces/namespaces/namespaces/status"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/namespaces/namespaces/status",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/%7Bnamespace%7D/namespaces/status",
},
{
// dynamic client with named group + namespace + resourceResource (with no name)
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/namespaces/namespaces/namespaces/namespaces/namespaces"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/namespaces/namespaces",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/%7Bnamespace%7D/namespaces",
},
{
// dynamic client with named group + resourceResource (with name) + subresource
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/namespaces/namespaces/namespaces/namespaces/finalize"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/namespaces/finalize",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/%7Bname%7D/finalize",
},
{
// dynamic client with named group + resourceResource (with name) + subresource
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/namespaces/namespaces/namespaces/namespaces/status"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/namespaces/status",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/%7Bname%7D/status",
},
{
// dynamic client with named group + resourceResource (with name)
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/namespaces/namespaces/namespaces/namespaces"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/namespaces",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces/%7Bname%7D",
},
{
// dynamic client with named group + resourceResource (with no name)
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/$RESOURCE/%NAME
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/apis/namespaces/namespaces/namespaces"),
ExpectedFullURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces",
ExpectedFinalURL: "http://localhost/some/base/url/path/apis/namespaces/namespaces/namespaces",
},
{
// dynamic client with wrong api group + namespace + resourceResource (with name) + subresource
// /apis/$NAMEDGROUPNAME/$RESOURCEVERSION/namespaces/$NAMESPACE/$RESOURCE/%NAME/$SUBRESOURCE
Request: NewRequest(nil, "DELETE", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil, 0).
Prefix("/pre1/namespaces/namespaces/namespaces/namespaces/namespaces/namespaces/finalize"),
ExpectedFullURL: "http://localhost/some/base/url/path/pre1/namespaces/namespaces/namespaces/namespaces/namespaces/namespaces/finalize",
ExpectedFinalURL: "http://localhost/%7Bprefix%7D",
},
}
actualURL := r.finalURLTemplate()
actual := actualURL.String()
expected := "http://localhost/pre1/namespaces/%7Bnamespace%7D/r1/%7Bname%7D?p0=%7Bvalue%7D"
if actual != expected {
t.Errorf("unexpected URL template: %s %s", actual, expected)
}
if r.URL().String() != full.String() {
t.Errorf("creating URL template changed request: %s -> %s", full.String(), r.URL().String())
for i, testCase := range testCases {
r := testCase.Request
full := r.URL()
if full.String() != testCase.ExpectedFullURL {
t.Errorf("%d: unexpected initial URL: %s %s", i, full, testCase.ExpectedFullURL)
}
actualURL := r.finalURLTemplate()
actual := actualURL.String()
if actual != testCase.ExpectedFinalURL {
t.Errorf("%d: unexpected URL template: %s %s", i, actual, testCase.ExpectedFinalURL)
}
if r.URL().String() != full.String() {
t.Errorf("%d, creating URL template changed request: %s -> %s", i, full.String(), r.URL().String())
}
}
}

View File

@@ -99,18 +99,20 @@ func NewDiscoveryRESTMapper(groupResources []*APIGroupResources) meta.RESTMapper
scope = meta.RESTScopeRoot
}
// this is for legacy resources and servers which don't list singular forms. For those we must still guess.
if len(resource.SingularName) == 0 {
versionMapper.Add(gv.WithKind(resource.Kind), scope)
// TODO this is producing unsafe guesses that don't actually work, but it matches previous behavior
versionMapper.Add(gv.WithKind(resource.Kind+"List"), scope)
// if we have a slash, then this is a subresource and we shouldn't create mappings for those.
if strings.Contains(resource.Name, "/") {
continue
}
plural := gv.WithResource(resource.Name)
singular := gv.WithResource(resource.SingularName)
versionMapper.AddSpecific(gv.WithKind(resource.Kind), plural, singular, scope)
// this is for legacy resources and servers which don't list singular forms. For those we must still guess.
if len(resource.SingularName) == 0 {
_, singular = meta.UnsafeGuessKindToResource(gv.WithKind(resource.Kind))
}
versionMapper.AddSpecific(gv.WithKind(strings.ToLower(resource.Kind)), plural, singular, scope)
versionMapper.AddSpecific(gv.WithKind(resource.Kind), plural, singular, scope)
// TODO this is producing unsafe guesses that don't actually work, but it matches previous behavior
versionMapper.Add(gv.WithKind(resource.Kind+"List"), scope)
}

View File

@@ -0,0 +1,69 @@
/*
Copyright 2015 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package leaderelection
import (
"net/http"
"sync"
"time"
)
// HealthzAdaptor associates the /healthz endpoint with the LeaderElection object.
// It helps deal with the /healthz endpoint being set up prior to the LeaderElection.
// This contains the code needed to act as an adaptor between the leader
// election code the health check code. It allows us to provide health
// status about the leader election. Most specifically about if the leader
// has failed to renew without exiting the process. In that case we should
// report not healthy and rely on the kubelet to take down the process.
type HealthzAdaptor struct {
pointerLock sync.Mutex
le *LeaderElector
timeout time.Duration
}
// Name returns the name of the health check we are implementing.
func (l *HealthzAdaptor) Name() string {
return "leaderElection"
}
// Check is called by the healthz endpoint handler.
// It fails (returns an error) if we own the lease but had not been able to renew it.
func (l *HealthzAdaptor) Check(req *http.Request) error {
l.pointerLock.Lock()
defer l.pointerLock.Unlock()
if l.le == nil {
return nil
}
return l.le.Check(l.timeout)
}
// SetLeaderElection ties a leader election object to a HealthzAdaptor
func (l *HealthzAdaptor) SetLeaderElection(le *LeaderElector) {
l.pointerLock.Lock()
defer l.pointerLock.Unlock()
l.le = le
}
// NewLeaderHealthzAdaptor creates a basic healthz adaptor to monitor a leader election.
// timeout determines the time beyond the lease expiry to be allowed for timeout.
// checks within the timeout period after the lease expires will still return healthy.
func NewLeaderHealthzAdaptor(timeout time.Duration) *HealthzAdaptor {
result := &HealthzAdaptor{
timeout: timeout,
}
return result
}

View File

@@ -0,0 +1,175 @@
/*
Copyright 2015 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package leaderelection
import (
"fmt"
"testing"
"time"
"k8s.io/apimachinery/pkg/util/clock"
rl "k8s.io/client-go/tools/leaderelection/resourcelock"
"net/http"
)
type fakeLock struct {
identity string
}
// Get is a dummy to allow us to have a fakeLock for testing.
func (fl *fakeLock) Get() (ler *rl.LeaderElectionRecord, err error) {
return nil, nil
}
// Create is a dummy to allow us to have a fakeLock for testing.
func (fl *fakeLock) Create(ler rl.LeaderElectionRecord) error {
return nil
}
// Update is a dummy to allow us to have a fakeLock for testing.
func (fl *fakeLock) Update(ler rl.LeaderElectionRecord) error {
return nil
}
// RecordEvent is a dummy to allow us to have a fakeLock for testing.
func (fl *fakeLock) RecordEvent(string) {}
// Identity is a dummy to allow us to have a fakeLock for testing.
func (fl *fakeLock) Identity() string {
return fl.identity
}
// Describe is a dummy to allow us to have a fakeLock for testing.
func (fl *fakeLock) Describe() string {
return "Dummy implementation of lock for testing"
}
// TestLeaderElectionHealthChecker tests that the healthcheck for leader election handles its edge cases.
func TestLeaderElectionHealthChecker(t *testing.T) {
current := time.Now()
req := &http.Request{}
tests := []struct {
description string
expected error
adaptorTimeout time.Duration
elector *LeaderElector
}{
{
description: "call check before leader elector initialized",
expected: nil,
adaptorTimeout: time.Second * 20,
elector: nil,
},
{
description: "call check when the the lease is far expired",
expected: fmt.Errorf("failed election to renew leadership on lease %s", "foo"),
adaptorTimeout: time.Second * 20,
elector: &LeaderElector{
config: LeaderElectionConfig{
Lock: &fakeLock{identity: "healthTest"},
LeaseDuration: time.Minute,
Name: "foo",
},
observedRecord: rl.LeaderElectionRecord{
HolderIdentity: "healthTest",
},
observedTime: current,
clock: clock.NewFakeClock(current.Add(time.Hour)),
},
},
{
description: "call check when the the lease is far expired but held by another server",
expected: nil,
adaptorTimeout: time.Second * 20,
elector: &LeaderElector{
config: LeaderElectionConfig{
Lock: &fakeLock{identity: "healthTest"},
LeaseDuration: time.Minute,
Name: "foo",
},
observedRecord: rl.LeaderElectionRecord{
HolderIdentity: "otherServer",
},
observedTime: current,
clock: clock.NewFakeClock(current.Add(time.Hour)),
},
},
{
description: "call check when the the lease is not expired",
expected: nil,
adaptorTimeout: time.Second * 20,
elector: &LeaderElector{
config: LeaderElectionConfig{
Lock: &fakeLock{identity: "healthTest"},
LeaseDuration: time.Minute,
Name: "foo",
},
observedRecord: rl.LeaderElectionRecord{
HolderIdentity: "healthTest",
},
observedTime: current,
clock: clock.NewFakeClock(current),
},
},
{
description: "call check when the the lease is expired but inside the timeout",
expected: nil,
adaptorTimeout: time.Second * 20,
elector: &LeaderElector{
config: LeaderElectionConfig{
Lock: &fakeLock{identity: "healthTest"},
LeaseDuration: time.Minute,
Name: "foo",
},
observedRecord: rl.LeaderElectionRecord{
HolderIdentity: "healthTest",
},
observedTime: current,
clock: clock.NewFakeClock(current.Add(time.Minute).Add(time.Second)),
},
},
}
for _, test := range tests {
adaptor := NewLeaderHealthzAdaptor(test.adaptorTimeout)
if adaptor.le != nil {
t.Errorf("[%s] leaderChecker started with a LeaderElector %v", test.description, adaptor.le)
}
if test.elector != nil {
test.elector.config.WatchDog = adaptor
adaptor.SetLeaderElection(test.elector)
if adaptor.le == nil {
t.Errorf("[%s] adaptor failed to set the LeaderElector", test.description)
}
}
err := adaptor.Check(req)
if test.expected == nil {
if err == nil {
continue
}
t.Errorf("[%s] called check, expected no error but received \"%v\"", test.description, err)
} else {
if err == nil {
t.Errorf("[%s] called check and failed to received the expected error \"%v\"", test.description, test.expected)
}
if err.Error() != test.expected.Error() {
t.Errorf("[%s] called check, expected %v, received %v", test.description, test.expected, err)
}
}
}
}

View File

@@ -55,6 +55,7 @@ import (
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/clock"
"k8s.io/apimachinery/pkg/util/runtime"
"k8s.io/apimachinery/pkg/util/wait"
rl "k8s.io/client-go/tools/leaderelection/resourcelock"
@@ -89,6 +90,7 @@ func NewLeaderElector(lec LeaderElectionConfig) (*LeaderElector, error) {
}
return &LeaderElector{
config: lec,
clock: clock.RealClock{},
}, nil
}
@@ -110,6 +112,13 @@ type LeaderElectionConfig struct {
// Callbacks are callbacks that are triggered during certain lifecycle
// events of the LeaderElector
Callbacks LeaderCallbacks
// WatchDog is the associated health checker
// WatchDog may be null if its not needed/configured.
WatchDog *HealthzAdaptor
// Name is the name of the resource lock for debugging
Name string
}
// LeaderCallbacks are callbacks that are triggered during certain
@@ -142,6 +151,12 @@ type LeaderElector struct {
// value observedRecord.HolderIdentity if the transition has
// not yet been reported.
reportedLeader string
// clock is wrapper around time to allow for less flaky testing
clock clock.Clock
// name is the name of the resource lock for debugging
name string
}
// Run starts the leader election loop
@@ -164,6 +179,9 @@ func RunOrDie(lec LeaderElectionConfig) {
if err != nil {
panic(err)
}
if lec.WatchDog != nil {
lec.WatchDog.SetLeaderElection(le)
}
le.Run()
}
@@ -239,14 +257,14 @@ func (le *LeaderElector) tryAcquireOrRenew() bool {
return false
}
le.observedRecord = leaderElectionRecord
le.observedTime = time.Now()
le.observedTime = le.clock.Now()
return true
}
// 2. Record obtained, check the Identity & Time
if !reflect.DeepEqual(le.observedRecord, *oldLeaderElectionRecord) {
le.observedRecord = *oldLeaderElectionRecord
le.observedTime = time.Now()
le.observedTime = le.clock.Now()
}
if le.observedTime.Add(le.config.LeaseDuration).After(now.Time) &&
oldLeaderElectionRecord.HolderIdentity != le.config.Lock.Identity() {
@@ -269,7 +287,7 @@ func (le *LeaderElector) tryAcquireOrRenew() bool {
return false
}
le.observedRecord = leaderElectionRecord
le.observedTime = time.Now()
le.observedTime = le.clock.Now()
return true
}
@@ -282,3 +300,19 @@ func (l *LeaderElector) maybeReportTransition() {
go l.config.Callbacks.OnNewLeader(l.reportedLeader)
}
}
// Check will determine if the current lease is expired by more than timeout.
func (le *LeaderElector) Check(maxTolerableExpiredLease time.Duration) error {
if !le.IsLeader() {
// Currently not concerned with the case that we are hot standby
return nil
}
// If we are more than timeout seconds after the lease duration that is past the timeout
// on the lease renew. Time to start reporting ourselves as unhealthy. We should have
// died but conditions like deadlock can prevent this. (See #70819)
if le.clock.Since(le.observedTime) > le.config.LeaseDuration+maxTolerableExpiredLease {
return fmt.Errorf("failed election to renew leadership on lease %s", le.config.Name)
}
return nil
}

View File

@@ -26,6 +26,7 @@ import (
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/util/clock"
fakecorev1 "k8s.io/client-go/kubernetes/typed/core/v1/fake"
core "k8s.io/client-go/testing"
rl "k8s.io/client-go/tools/leaderelection/resourcelock"
@@ -257,6 +258,7 @@ func testTryAcquireOrRenew(t *testing.T, objectType string) {
config: lec,
observedRecord: test.observedRecord,
observedTime: test.observedTime,
clock: clock.RealClock{},
}
if test.expectSuccess != le.tryAcquireOrRenew() {

View File

@@ -129,7 +129,7 @@ func SetAuthProxyHeaders(req *http.Request, username string, groups []string, ex
}
for key, values := range extra {
for _, value := range values {
req.Header.Add("X-Remote-Extra-"+key, value)
req.Header.Add("X-Remote-Extra-"+headerKeyEscape(key), value)
}
}
}
@@ -246,7 +246,7 @@ func (rt *impersonatingRoundTripper) RoundTrip(req *http.Request) (*http.Respons
}
for k, vv := range rt.impersonate.Extra {
for _, v := range vv {
req.Header.Add(ImpersonateUserExtraHeaderPrefix+k, v)
req.Header.Add(ImpersonateUserExtraHeaderPrefix+headerKeyEscape(k), v)
}
}
@@ -422,3 +422,110 @@ func (rt *debuggingRoundTripper) RoundTrip(req *http.Request) (*http.Response, e
func (rt *debuggingRoundTripper) WrappedRoundTripper() http.RoundTripper {
return rt.delegatedRoundTripper
}
func legalHeaderByte(b byte) bool {
return int(b) < len(legalHeaderKeyBytes) && legalHeaderKeyBytes[b]
}
func shouldEscape(b byte) bool {
// url.PathUnescape() returns an error if any '%' is not followed by two
// hexadecimal digits, so we'll intentionally encode it.
return !legalHeaderByte(b) || b == '%'
}
func headerKeyEscape(key string) string {
buf := strings.Builder{}
for i := 0; i < len(key); i++ {
b := key[i]
if shouldEscape(b) {
// %-encode bytes that should be escaped:
// https://tools.ietf.org/html/rfc3986#section-2.1
fmt.Fprintf(&buf, "%%%02X", b)
continue
}
buf.WriteByte(b)
}
return buf.String()
}
// legalHeaderKeyBytes was copied from net/http/lex.go's isTokenTable.
// See https://httpwg.github.io/specs/rfc7230.html#rule.token.separators
var legalHeaderKeyBytes = [127]bool{
'%': true,
'!': true,
'#': true,
'$': true,
'&': true,
'\'': true,
'*': true,
'+': true,
'-': true,
'.': true,
'0': true,
'1': true,
'2': true,
'3': true,
'4': true,
'5': true,
'6': true,
'7': true,
'8': true,
'9': true,
'A': true,
'B': true,
'C': true,
'D': true,
'E': true,
'F': true,
'G': true,
'H': true,
'I': true,
'J': true,
'K': true,
'L': true,
'M': true,
'N': true,
'O': true,
'P': true,
'Q': true,
'R': true,
'S': true,
'T': true,
'U': true,
'W': true,
'V': true,
'X': true,
'Y': true,
'Z': true,
'^': true,
'_': true,
'`': true,
'a': true,
'b': true,
'c': true,
'd': true,
'e': true,
'f': true,
'g': true,
'h': true,
'i': true,
'j': true,
'k': true,
'l': true,
'm': true,
'n': true,
'o': true,
'p': true,
'q': true,
'r': true,
's': true,
't': true,
'u': true,
'v': true,
'w': true,
'x': true,
'y': true,
'z': true,
'|': true,
'~': true,
}

View File

@@ -18,6 +18,7 @@ package transport
import (
"net/http"
"net/url"
"reflect"
"strings"
"testing"
@@ -125,6 +126,32 @@ func TestImpersonationRoundTripper(t *testing.T) {
ImpersonateUserExtraHeaderPrefix + "Second": {"B", "b"},
},
},
{
name: "escape handling",
impersonationConfig: ImpersonationConfig{
UserName: "user",
Extra: map[string][]string{
"test.example.com/thing.thing": {"A", "a"},
},
},
expected: map[string][]string{
ImpersonateUserHeader: {"user"},
ImpersonateUserExtraHeaderPrefix + `Test.example.com%2fthing.thing`: {"A", "a"},
},
},
{
name: "double escape handling",
impersonationConfig: ImpersonationConfig{
UserName: "user",
Extra: map[string][]string{
"test.example.com/thing.thing%20another.thing": {"A", "a"},
},
},
expected: map[string][]string{
ImpersonateUserHeader: {"user"},
ImpersonateUserExtraHeaderPrefix + `Test.example.com%2fthing.thing%2520another.thing`: {"A", "a"},
},
},
}
for _, tc := range tcs {
@@ -159,9 +186,10 @@ func TestImpersonationRoundTripper(t *testing.T) {
func TestAuthProxyRoundTripper(t *testing.T) {
for n, tc := range map[string]struct {
username string
groups []string
extra map[string][]string
username string
groups []string
extra map[string][]string
expectedExtra map[string][]string
}{
"allfields": {
username: "user",
@@ -170,6 +198,34 @@ func TestAuthProxyRoundTripper(t *testing.T) {
"one": {"alpha", "bravo"},
"two": {"charlie", "delta"},
},
expectedExtra: map[string][]string{
"one": {"alpha", "bravo"},
"two": {"charlie", "delta"},
},
},
"escaped extra": {
username: "user",
groups: []string{"groupA", "groupB"},
extra: map[string][]string{
"one": {"alpha", "bravo"},
"example.com/two": {"charlie", "delta"},
},
expectedExtra: map[string][]string{
"one": {"alpha", "bravo"},
"example.com%2ftwo": {"charlie", "delta"},
},
},
"double escaped extra": {
username: "user",
groups: []string{"groupA", "groupB"},
extra: map[string][]string{
"one": {"alpha", "bravo"},
"example.com/two%20three": {"charlie", "delta"},
},
expectedExtra: map[string][]string{
"one": {"alpha", "bravo"},
"example.com%2ftwo%2520three": {"charlie", "delta"},
},
},
} {
rt := &testRoundTripper{}
@@ -210,9 +266,64 @@ func TestAuthProxyRoundTripper(t *testing.T) {
actualExtra[extraKey] = append(actualExtra[key], values...)
}
}
if e, a := tc.extra, actualExtra; !reflect.DeepEqual(e, a) {
if e, a := tc.expectedExtra, actualExtra; !reflect.DeepEqual(e, a) {
t.Errorf("%s expected %v, got %v", n, e, a)
continue
}
}
}
// TestHeaderEscapeRoundTrip tests to see if foo == url.PathUnescape(headerEscape(foo))
// This behavior is important for client -> API server transmission of extra values.
func TestHeaderEscapeRoundTrip(t *testing.T) {
t.Parallel()
testCases := []struct {
name string
key string
}{
{
name: "alpha",
key: "alphabetical",
},
{
name: "alphanumeric",
key: "alph4num3r1c",
},
{
name: "percent encoded",
key: "percent%20encoded",
},
{
name: "almost percent encoded",
key: "almost%zzpercent%xxencoded",
},
{
name: "illegal char & percent encoding",
key: "example.com/percent%20encoded",
},
{
name: "weird unicode stuff",
key: "example.com/ᛒᚥᛏᛖᚥᚢとロビン",
},
{
name: "header legal chars",
key: "abc123!#$+.-_*\\^`~|'",
},
{
name: "legal path, illegal header",
key: "@=:",
},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
escaped := headerKeyEscape(tc.key)
unescaped, err := url.PathUnescape(escaped)
if err != nil {
t.Fatalf("url.PathUnescape(%q) returned error: %v", escaped, err)
}
if tc.key != unescaped {
t.Errorf("url.PathUnescape(headerKeyEscape(%q)) returned %q, wanted %q", tc.key, unescaped, tc.key)
}
})
}
}