7 Commits

Author SHA1 Message Date
Tobin Feldman-Fitzthum
e057107751 sc: add Tobin to SC for NVIDIA
NVIDIA has been a major contributor to Confidential Containers and more
contributions are coming.

As such, let's expand the NVIDIA representation on the SC to two seats.

Signed-off-by: Tobin Feldman-Fitzthum <tfeldmanfitz@nvidia.com>
2025-10-21 09:04:31 -04:00
Tobin Feldman-Fitzthum
bfcdf18bfa Revert "sc: add Tobin to SC for NVIDIA"
This has to be approved by 2/3rds of the SC.

Signed-off-by: Tobin Feldman-Fitzthum <tfeldmanfitz@nvidia.com>
2025-10-17 09:18:09 -04:00
Ariel Adam
c771c13f06 Merge pull request #324 from fitzthum/add-sc
sc: add Tobin to SC for NVIDIA
2025-10-17 12:37:45 +03:00
Tobin Feldman-Fitzthum
595f5a4dd4 sc: add Tobin to SC for NVIDIA
NVIDIA has been a major contributor to Confidential Containers and more
contributions are coming.

As such, let's expand the NVIDIA representation on the SC to two seats.

Signed-off-by: Tobin Feldman-Fitzthum <tfeldmanfitz@nvidia.com>
2025-10-16 09:42:50 -07:00
Tobin Feldman-Fitzthum
746a505f20 governance: replace myself on the steering committee
Since I no longer work at IBM, I can no longer occupy an IBM seat on the
steering commitee. Pursuant to the replacement clause of the governance
document, I am replacing myself with Nina Goradia from IBM. This does
not require a steering committee vote, but it must be approved by the
other IBM representative, James Magowan.

I think Nina will be a great fit for the steering commitee.

Thanks for a wonderful chapter.

Signed-off-by: Tobin Feldman-Fitzthum <tfeldmanfitz@nvidia.com>
2025-10-13 10:51:20 -04:00
Tobin Feldman-Fitzthum
0c97c4b0a7 release: update release checklist
Remove the step where we poke Wainer. His arm is getting sore and it
doesn't seem like the project is widely consumed via operator hub.

Also, add post-release steps for guest-components.

Note that we are not updating the Trustee k8s yaml to point to the
release version. If we want to do this, it has to happen much earlier in
the process (before we bump Kata to use the new version of Trustee).

Signed-off-by: Tobin Feldman-Fitzthum <tobinf@protonmail.com>
2025-10-08 09:06:29 -04:00
Dan Middleton
718fee9f11 Add unit test requirement
Documenting best practice that all new features need to come with unit
tests. This satisfies https://www.bestpractices.dev/en/projects/5719#quality

Signed-off-by: Dan Middleton <dmiddleton@nvidia.com>
2025-09-30 07:51:47 +03:00
4 changed files with 41 additions and 15 deletions

View File

@@ -20,6 +20,7 @@ flowchart LR
Guest-Components .-> Client-tool
Guest-Components --> enclave-agent
enclave-cc --> kustomization.yaml
Operator --> versions.yaml
Guest-Components --> versions.yaml
Trustee --> versions.yaml
Kata --> versions.yaml
@@ -47,7 +48,8 @@ flowchart LR
Starting with v0.9.0 the release process no longer involves centralized dependency management.
In other words, when doing a CoCo release, we don't push the most recent versions of the subprojects
into Kata and enclave-cc. Instead, dependencies should be updated during the normal process of development.
Releases of most subprojects are now decoupled from releases of the CoCo project.
After the release, we typically cut a release of the subprojects that reflects whatever commit was used
in the Kata release.
## The Steps
@@ -72,13 +74,9 @@ Identify/create the bundles that we will release for Kata and enclave-cc.
If you absolutely cannot use a Kata release,
you can consider releasing one of these bundles.
- [ ] 3. :eyes: **Create a peer pods release**
### Update the Operator
Create a peer pods release based on the Kata release, by following the [documented flow](https://github.com/confidential-containers/cloud-api-adaptor/blob/main/docs/Release-Process.md).
### Test Release with Operator
- [ ] 4. :eyes: **Check operator pre-installation and open PR if needed**
- [ ] 3. :eyes: **Check operator pre-installation and open PR if needed**
The operator uses a pre-install container to setup the node.
Check that the container matches the dependencies used in Kata
@@ -88,7 +86,7 @@ Identify/create the bundles that we will release for Kata and enclave-cc.
* Compare the `nydus-snapshotter` version in Kata [versions.yaml](https://github.com/kata-containers/kata-containers/blob/main/versions.yaml) (search for `nydus-snapshotter` and check its `version` field) with the [Makefile](https://github.com/confidential-containers/operator/blob/main/install/pre-install-payload/Makefile) (check the `NYDUS_SNAPSHOTTER_VERSION` value) for the operator pre-install container.
* **If they do not match, stop and open a PR now. In the PR, update the operator's Makefile to match the version used in kata. After the PR is merged, continue.**
- [ ] 5. :wrench: **Open a PR to the operator to update the release artifacts**
- [ ] 4. :wrench: **Open a PR to the operator to update the release artifacts**
Update the operator to use the payloads identified in steps 1, 2, 3, and 4.
@@ -114,13 +112,39 @@ Identify/create the bundles that we will release for Kata and enclave-cc.
### Final Touches
- [ ] 6. :trophy: **Cut an operator release using the GitHub release tool**
- [ ] 5. :trophy: **Cut an operator release using the GitHub release tool**
- [ ] 6. :wrench: **Create a peer pods release**
Create a peer pods release based on the Kata release, by following the [documented flow](https://github.com/confidential-containers/cloud-api-adaptor/blob/main/docs/Release-Process.md).
- [ ] 7. :green_book: **Make sure to update the [release notes](https://github.com/confidential-containers/confidential-containers/tree/main/releases) and tag/release the confidential-containers repo using the GitHub release tool.**
- [ ] 8. :hammer: **Poke Wainer Moschetta (@wainersm) to update the release to the OperatorHub. Find the documented flow [here](https://github.com/confidential-containers/operator/blob/main/docs/OPERATOR_HUB.md).**
### Post-release
- [ ] 9. :wrench: **Open a PR to the operator to go back to latest payloads after release**
- [ ] 8. :wrench: **Open a PR to the operator to go back to latest payloads after release**
After the release, the operator's payloads need to go back to what they were (e.g. using "latest" instead of a specific commit sha). As an example, the v0.9.0-alpha1 release applied [these changes](https://github.com/confidential-containers/operator/pull/389/files). You should use `git revert -s` for this.
- [ ] 9. :pushpin: **Tag the version of guest-components used in the release**.
Go look at [versions.yaml](https://github.com/kata-containers/kata-containers/blob/main/versions.yaml)
in Kata Containers and find the version of the guest-components that was used in the Kata release.
Tag this commit in guest-components with the latest version of guest components.
Note that the version of guest-components might not be the same as the version of CoCo.
- [ ] 10. :scissors: **Cut a release of guest-components using GitHub release tool**
- [ ] 11. :pushpin: **Tag the version of Trustee used in the release**
Follow the same process as step 9 but for Trustee.
- [ ] 12. :scissors: **Cut a release of Trustee using GitHub release tool**
- [ ] 13. :wrench: **Tag the Trustee release images**
Use the Trustee release helper script to push the CI images corresponding to the released hash
as the release images.
- [ ] 14. :pushpin: **Tag the latest version of the website for the release**
Make sure the website is up-to-date for the latest release, and then tag the repo.

View File

@@ -78,6 +78,8 @@ with the community as early as possible. Consider making an `RFC` issue
that explains the changes. You might also try to break large contributions
into smaller steps.
Any new feature must be accompanied by new unit tests.
### Making a Pull Request
If you aren't familiar with Git or the GitHub PR workflow, take a look at [this section](https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#github-workflow)

View File

@@ -7,11 +7,11 @@ bpradipt, Pradipta Banerjee, Redhat
peterzcst, Peter Zhu, Intel
mythi, Mikko Ylinen, Intel
magowan, James Magowan, IBM
fitzthum, Tobin Feldman-Fitzthum, IBM
jiazhang0, Zhang Jia, Alibaba
jiangliu, Jiang Liu, Alibaba
ryansavino, Ryan Savino, AMD
sameo, Samuel Ortiz, Rivos
zvonkok, Zvonko Kaiser, NVIDIA
fitzthum, Tobin Feldman-Fitzthum, NVIDIA
vbatts, Vincent Batts, Microsoft
danmihai1, Dan Mihai, Microsoft

View File

@@ -87,11 +87,11 @@ The current members of the SC are:
* Ryan Savino (@ryansavino) - AMD
* Jiang Liu (@jiangliu) and Jia Zhang (@jiazhang0) - Alibaba
* James Magowan (@magowan) and Tobin Feldman-Fitzthum (@fitzthum) - IBM
* James Magowan (@magowan) and Nina Goradia (@ninag) - IBM
* Peter Zhu (@peterzcst) and Mikko Ylinen (@mythi) - Intel
* Pradipta Banerjee (@bpradipt) and Ariel Adam (@ariel-adam) - Red Hat
* Samuel Ortiz (@sameo) - Rivos
* Zvonko Kaiser (@zvonkok) - NVIDIA
* Zvonko Kaiser (@zvonkok) and Tobin Feldman-Fitzthum (@fitzthum) - NVIDIA
* Vincent Batts (@vbatts) and Dan Mihai (@danmihai1) - Microsoft
### Emeritus Members