Commit Graph

5698 Commits

Author SHA1 Message Date
João Pereira
4d613f771f feat(registry): Make graceful shutdown test robust (#4720) 2025-10-19 15:09:29 +01:00
Sumedh Vats
edde36cd9e feat(registry): Make graceful shutdown test robust
The `TestGracefulShutdown` test was failing intermittently, especially
with stricter HTTP handling in newer Go versions (e.g., 1.25). This was
caused by sending an incomplete HTTP request in two separate writes,
creating a race condition where the server could shut down before
receiving the full request.

This commit fixes the test's flakiness by sending a single, complete,
and valid HTTP/1.1 request before triggering the shutdown. This ensures
the test accurately verifies the intended behavior: that a valid,
in-flight request is fully processed while new connections are rejected.

Fixes:#4696
Signed-off-by: Sumedh Vats <sumedhvats2004@gmail.com>
2025-10-18 00:35:54 +05:30
João Pereira
76fe617052 client: add Accept headers to Exists() HEAD (#4715) 2025-10-16 08:25:37 +01:00
Milos Gajdos
8ce8219982 chore: labeler: add area/client mapping for internal/client/** (#4716) 2025-10-15 08:59:39 -07:00
Artem Tkachuk
0e77b28593 chore: labeler: add area/client mapping for internal/client/**
Signed-off-by: Artem Tkachuk <artemtkachuk@yahoo.com>
2025-10-14 12:10:04 -07:00
Artem Tkachuk
2f1a51dc72 client: add Accept headers to Exists() HEAD
The manifest Exists() client call issued a HEAD without any Accept
headers. Some OCI-focused registries require an explicit Accept for
manifest content negotiation, causing HEAD to fail (404/406) even
when the manifest exists. The Get() path already sets Accept;
Exists() did not.

This change adds all supported manifest media types from
distribution.ManifestMediaTypes() as Accept headers to the Exists()
HEAD request, aligning behavior with Get() and improving OCI
interoperability.

Tests:
- Regression: Exists() returns true when Accept is present and
  false when stripped (negative path), mirroring real-world
  behavior.

Risk/compatibility:
- Low. Registries that ignore Accept on HEAD continue to work.
- Redirect handling is unchanged; existing CheckRedirect preserves
  Accept.

Signed-off-by: Artem Tkachuk <artemtkachuk@yahoo.com>
2025-10-13 23:52:12 -07:00
Milos Gajdos
283bd92b78 build(deps): bump github/codeql-action from 4.30.7 to 4.30.8 (#4714) 2025-10-13 10:38:34 -07:00
dependabot[bot]
ad5d9994df build(deps): bump github/codeql-action from 4.30.7 to 4.30.8
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.30.7 to 4.30.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Commits](https://github.com/github/codeql-action/compare/v4.30.7...v4.30.8)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.30.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-13 01:09:49 +00:00
João Pereira
7d4be412e9 build(deps): bump github/codeql-action from 3.26.5 to 4.30.7 (#4710) 2025-10-08 07:16:29 +01:00
dependabot[bot]
6d7645869a build(deps): bump github/codeql-action from 3.26.5 to 4.30.7
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.5 to 4.30.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Commits](https://github.com/github/codeql-action/compare/v3.26.5...v4.30.7)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.30.7
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-08 01:09:36 +00:00
João Pereira
d595e0a170 build(deps): bump ossf/scorecard-action from 2.4.2 to 2.4.3 (#4706) 2025-10-01 07:59:10 +01:00
dependabot[bot]
11519e6d92 build(deps): bump ossf/scorecard-action from 2.4.2 to 2.4.3
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.2 to 2.4.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](05b42c6244...4eaacf0543)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-version: 2.4.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-01 01:11:01 +00:00
Milos Gajdos
4ead5a1085 build(deps): bump actions/upload-pages-artifact from 3 to 4 (#4691) 2025-09-16 22:52:56 -07:00
João Pereira
cf6a5ce346 build(deps): bump actions/setup-go from 5 to 6 (#4693) 2025-09-05 09:17:48 +01:00
João Pereira
6de7cd9d0d build(deps): bump actions/labeler from 5 to 6 (#4694) 2025-09-05 09:17:10 +01:00
dependabot[bot]
99c47b61cc build(deps): bump actions/labeler from 5 to 6
Bumps [actions/labeler](https://github.com/actions/labeler) from 5 to 6.
- [Release notes](https://github.com/actions/labeler/releases)
- [Commits](https://github.com/actions/labeler/compare/v5...v6)

---
updated-dependencies:
- dependency-name: actions/labeler
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-05 01:07:42 +00:00
dependabot[bot]
e1e5d05113 build(deps): bump actions/setup-go from 5 to 6
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-05 01:07:37 +00:00
Milos Gajdos
979a07472e fix(registry/handlers/app): redis CAs (#4668) 2025-09-03 07:06:09 -07:00
dependabot[bot]
f5512709bf build(deps): bump actions/upload-pages-artifact from 3 to 4
Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-pages-artifact/releases)
- [Commits](https://github.com/actions/upload-pages-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-pages-artifact
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-25 02:21:26 +00:00
João Pereira
412a8ae033 Fix broken link to Docker Hub fair use policy (#4688) 2025-08-13 22:09:25 +01:00
Andy Castille
0fb77d6a75 Fix broken link to Docker Hub fair use policy
Signed-off-by: Andy Castille <me@andycc.dev>
2025-08-13 12:23:30 -07:00
João Pereira
f2b08cd917 build(deps): bump actions/checkout from 4 to 5 (#4687) 2025-08-12 16:02:09 +01:00
dependabot[bot]
251bf1b923 build(deps): bump actions/checkout from 4 to 5
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Commits](https://github.com/actions/checkout/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-12 13:08:10 +00:00
Wang Yan
8c60ad709b Fixes #4683 - uses X/Y instead of Gx/Gy for thumbprint of ecdsa keys (#4684) 2025-08-12 13:41:12 +08:00
João Pereira
7f2dad4420 Fixed data race in TestSchedule test (#4647) 2025-08-11 23:25:37 +01:00
Guillaume pelletier
6e59b82417 Fixes #4683 - uses X/Y instead of Gx/Gy for thumbprint of ecdsa keys
Signed-off-by: Guillaume Pelletier <guillaume.pelletier@genaiz.com>
2025-08-11 10:29:53 -04:00
Milos Gajdos
7d74ee7186 Fix S3 driver loglevel param (#4617) 2025-08-11 14:27:41 +01:00
Milos Gajdos
0966daece7 docs: Add OpenTelemetry links to quickstart docs (#4270) (#4640) 2025-08-11 14:25:47 +01:00
Wang Yan
c54bcb3770 s3-aws: fix build for 386 (#4642) 2025-08-11 14:14:53 +08:00
Wang Yan
f6e54e6189 refactor: replace map iteration with maps.Copy/Clone (#4632) 2025-08-11 13:28:07 +08:00
Milos Gajdos
f9fa205992 Switch UUIDs to UUIDv7 (#4666) 2025-08-08 19:11:24 +01:00
Raj Siva-Rajah
b559f27a08 Switch to UUIDv7
Signed-off-by: Raj Siva-Rajah <raj@zapzap.cloud>
2025-07-31 06:54:27 +00:00
Milos Gajdos
e7b4fa06f2 Fix markdown syntax for OTEL traces link in docs (#4676) 2025-07-22 18:45:15 +01:00
Shan Desai
b39441b1e6 Fix markdown syntax for OTEL traces link in docs
square brackets and the respective parentheses for a markdown link were falsely typed in causing readability issues.  This commit fixes the markdown syntax for the same

Signed-off-by: Shan Desai <shantanoo.desai@gmail.com>
2025-07-22 12:28:31 +02:00
Milos Gajdos
c9760ebe95 fix: set OTEL traces to disabled by default (#4671) 2025-07-10 07:44:49 -07:00
Pat Riehecky
53dde7fc86 fix: set OTEL traces to disabled by default
If you want to enable traces, you can still set the env to your
collector.

Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
2025-07-09 13:54:43 -05:00
Milos Gajdos
17dc6f9cda docs: Add note about OTEL_TRACES_EXPORTER (#4669) 2025-07-09 11:27:44 -07:00
Pat Riehecky
68cd681bad docs: Add note about OTEL_TRACES_EXPORTER
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
2025-07-09 10:42:32 -05:00
ChandonPierre
1fc8461710 fix tests
Signed-off-by: ChandonPierre <cpierre@coreweave.com>
2025-07-05 19:36:44 -04:00
ChandonPierre
02b1f6e3af fix(registry/handlers/app): redis CAs
`configureRedis` currently sets `RequireAndVerifyClientCert` and `ClientCAs`, however these are server side mTLS configurations, and do not apply for the client initiating the handshake.

Since we never actually set client side `RootCAs`, connecting to Redis with a self-signed CA results in:

```
"error": "tls: failed to verify certificate: x509: certificate signed by unknown authority",
```
Fixed by switching Redis TLS config to use `RootCAs` instead, and updating configuration accordingly.

Signed-off-by: ChandonPierre <cpierre@coreweave.com>
2025-07-05 15:25:17 -04:00
Artem Khoroshev
bb278c2be6 fix: fixed data race in TestSchedule test
Signed-off-by: Artem Khoroshev <horoshev.artem@yandex.ru>
2025-06-06 20:12:59 +03:00
Milos Gajdos
da404778ed build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2 (#4645) 2025-06-02 07:46:14 -07:00
dependabot[bot]
b09be3d605 build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](f49aabe0b5...05b42c6244)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-version: 2.4.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-02 01:26:19 +00:00
Chen Qi
6970080b10 s3-aws: fix build for 386
When building for 386, we got the following build error:

  registry/storage/driver/s3-aws/s3.go:312:99: cannot use
  maxChunkSize (untyped int constant 5368709120) as int value
  in argument to getParameterAsInteger (overflows)

This is because the s3_64bit.go is used. Adjust the build tag matching
in s3_32bit.go and s3_64bit.go to fix this issue.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
2025-05-29 11:35:59 +08:00
Dane Wagner
e629f88670 docs: Add OpenTelemetry links to quickstart docs (#4270)
Signed-off-by: Dane Wagner <dane.wagner@gmail.com>
2025-05-23 12:02:47 -05:00
Milos Gajdos
97495e5397 Fix: resolve issue #4478 by using a temporary file for non-append writes (#4624) 2025-05-19 07:37:07 -07:00
Oded Porat
dde1e49f23 Changes:
Append a UUID to ensure uniqueness
Join delete error

Signed-off-by: Oded Porat <onporat@gmail.com>
2025-05-04 10:43:19 +03:00
whosehang
fea3638384 refactor: replace map iteration with maps.Copy/Clone
Signed-off-by: whosehang <whosehang@outlook.com>
2025-05-03 09:24:10 +08:00
Milos Gajdos
95647cba1d feat: extract redis config to separate struct (#4620) 2025-04-29 06:21:55 -07:00
Milos Gajdos
45e5f78dd9 fix: Annotate code block from validation.indexes configuration docs (#4629) 2025-04-28 06:48:17 -07:00