github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-08-28 19:00:48 +00:00
Code Issues Projects Releases Wiki Activity

update(rule_loader): remove the warning on the required_engine_version

Browse Source 
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
This commit is contained in:
Andrea Terzolo 2024-01-09 12:33:58 +01:00 committed by poiana
parent f5dea33b5e
commit 56de6e6786
3 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
unit_tests/engine/test_rule_loader.cpp
View File

@ -583,7 +583,7 @@ TEST_F(engine_loader_test, required_engine_version_not_semver)
)END";
ASSERT_TRUE(load_rules(rules_content, "rules.yaml"));
ASSERT_TRUE(check_warning_message(WARNING_ENGINE_VERSION_NOT_SEMVER));
ASSERT_FALSE(has_warnings());
}
TEST_F(engine_loader_test, required_engine_version_invalid)

1
userspace/engine/rule_loader_reader.cpp
View File

@ -368,7 +368,6 @@ static void read_item(
// Build proper semver representation
v.version = rule_loader::reader::get_implicit_engine_version(ver);
cfg.res->add_warning(falco::load_result::LOAD_DEPRECATED_ITEM, WARNING_ENGINE_VERSION_NOT_SEMVER, ctx);
}
catch(std::exception& e)
{

3
userspace/engine/rule_loader_reader.h
View File

@ -32,9 +32,6 @@ limitations under the License.
// Warning message used when `enabled` is used without override.
#define WARNING_ENABLED_MESSAGE "The standalone 'enabled' key usage is deprecated. The correct approach requires also a 'replace' entry under the 'override' key (i.e. 'enabled: replace')."
// Warning message used when the `required_engine_version` is not semver compatible.
#define WARNING_ENGINE_VERSION_NOT_SEMVER "The 'required_engine_version' should be SemVer compatible. All non-SemVer compatible values are deprecated."
namespace rule_loader
{