github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-06-26 06:42:08 +00:00
Code Issues Projects Releases Wiki Activity

fix(c++): refactor member initialization in constructor initialization list

Browse Source 
Reported by cppcheck

Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>

# Conflicts:
#	userspace/engine/falco_common.h
This commit is contained in:
Samuel Gaist 2024-02-12 17:03:16 +01:00 committed by poiana
parent 8bc32d248e
commit f6498cd8bd
4 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
userspace/engine/falco_common.h
View File

@ -45,8 +45,8 @@ struct falco_exception : std::exception
}
explicit falco_exception(std::string error_str)
: m_error_str(error_str)
{
m_error_str = error_str;
}
char const* what() const throw()

12
userspace/falco/app/state.h
View File

@ -72,18 +72,18 @@ struct state
state():
restart(false),
config(std::make_shared<falco_configuration>()),
outputs(nullptr),
engine(std::make_shared<falco_engine>()),
loaded_sources(),
enabled_sources(),
offline_inspector(std::make_shared<sinsp>()),
source_infos(),
plugin_configs(),
selected_sc_set(),
syscall_buffer_bytes_size(DEFAULT_DRIVER_BUFFER_BYTES_DIM)
syscall_buffer_bytes_size(DEFAULT_DRIVER_BUFFER_BYTES_DIM),
restarter(nullptr)
{
config = std::make_shared<falco_configuration>();
engine = std::make_shared<falco_engine>();
offline_inspector = std::make_shared<sinsp>();
outputs = nullptr;
restarter = nullptr;
}
state(const std::string& cmd, const falco::app::options& opts): state()

5
userspace/falco/stats_writer.cpp
View File

@ -169,9 +169,10 @@ stats_writer::ticker_t stats_writer::get_ticker()
stats_writer::stats_writer(
const std::shared_ptr<falco_outputs>& outputs,
const std::shared_ptr<const falco_configuration>& config)
: m_initialized(false), m_total_samples(0)
: m_initialized(false)
, m_total_samples(0)
, m_config(config)
{
m_config = config;
if (config->m_metrics_enabled)
{
/* m_outputs should always be initialized because we use it

15
userspace/falco/versions_info.cpp
View File

@ -49,14 +49,15 @@ static inline std::string get_driver_schema_version(const std::shared_ptr<sinsp>
}
falco::versions_info::versions_info(const std::shared_ptr<sinsp>& inspector)
: falco_version(FALCO_VERSION)
, engine_version(FALCO_ENGINE_VERSION)
, libs_version(FALCOSECURITY_LIBS_VERSION)
, plugin_api_version(inspector->get_plugin_api_version())
, driver_api_version(get_driver_api_version(inspector))
, driver_schema_version(get_driver_schema_version(inspector))
, default_driver_version(DRIVER_VERSION)
{
falco_version = FALCO_VERSION;
engine_version = FALCO_ENGINE_VERSION;
libs_version = FALCOSECURITY_LIBS_VERSION;
plugin_api_version = inspector->get_plugin_api_version();
driver_api_version = get_driver_api_version(inspector);
driver_schema_version = get_driver_schema_version(inspector);
default_driver_version = DRIVER_VERSION;
for (const auto &p : inspector->get_plugin_manager()->plugins())
{
plugin_versions[p->name()] = p->plugin_version().as_string();