ci: actionlint: Address issues and set as required

Address issues just introduced and set actionlint as a required by removing
the path filter.

Signed-off-by: Aurélien Bombo <abombo@microsoft.com>

.github/workflows/actionlint.yaml

@@ -3,17 +3,9 @@ name: Lint GHA workflows
 on:
   workflow_dispatch:
   pull_request:
-    types:
-      - opened
-      - edited
-      - reopened
-      - synchronize
-    paths:
-      - '.github/workflows/**'
 
 permissions: {}
 
-
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
   cancel-in-progress: true

.github/workflows/build-checks-preview-riscv64.yaml

@@ -124,7 +124,7 @@ jobs:
           echo "GITHUB_RUNNER_CI_NON_VIRT=true" >> "$GITHUB_ENV"
       - name: Running `${{ matrix.command }}` for ${{ matrix.component.name }}
         run: |
-          cd ${COMPONENT_PATH}
+          cd "${COMPONENT_PATH}"
           ${COMMAND}
         env:
           COMMAND: ${{ matrix.command }}

.github/workflows/build-checks.yaml

@@ -128,7 +128,7 @@ jobs:
       - name: Running `${{ matrix.command }}` for ${{ matrix.component.name }}
         run: |
           cd "${COMPONENT_PATH}"
-          eval ${COMMAND}
+          eval "${COMMAND}"
         env:
           COMMAND: ${{ matrix.command }}
           COMPONENT_PATH: ${{ matrix.component.path }}

.github/workflows/govulncheck.yaml

@@ -40,7 +40,7 @@ jobs:
       - name: Build runtime binaries
         run: |
           cd src/runtime
-          make ${MAKE_TARGET}
+          make "${MAKE_TARGET}"
         env:
           MAKE_TARGET: ${{ matrix.make_target }}
           SKIP_GO_VERSION_CHECK: "1"

.github/workflows/run-k8s-tests-on-zvsi.yaml

@@ -108,7 +108,7 @@ jobs:
       - name: Configure the ${{ matrix.snapshotter }} snapshotter
         env:
           DEPLOY_CMD: ${{ matrix.deploy-cmd }}
-        run: bash tests/integration/kubernetes/gha-run.sh ${DEPLOY_CMD}
+        run: bash tests/integration/kubernetes/gha-run.sh "${DEPLOY_CMD}"
         if: ${{ matrix.snapshotter != 'overlayfs' }}
 
       - name: Deploy Kata

.github/workflows/static-checks.yaml

@@ -91,7 +91,7 @@ jobs:
         run: |
           export PATH="$PATH:${HOME}/.cargo/bin"
           cd "${COMPONENT_PATH}"
-          eval ${COMMAND}
+          eval "${COMMAND}"
         env:
           COMMAND: ${{ matrix.command }}
           COMPONENT_PATH: ${{ matrix.component-path }}

tools/testing/gatekeeper/required-tests.yaml

@@ -7,6 +7,7 @@ required_tests:
   # TODO: cargo-deny-runner.yaml not yet treated as conditional
   - Cargo Crates Check Runner / cargo-deny-runner
   - GHA security analysis / zizmor
+  - Lint GHA workflows / run-actionlint
 
 required_regexps:
   # Always required regexps