github/kata-containers
1
0
Fork 2
mirror of https://github.com/kata-containers/kata-containers.git synced 2026-04-27 02:56:50 +00:00
Code Issues Projects Releases Wiki Activity

tools: Fix shellcheck issues in rootfs_lib.sh

Browse Source 
Fix shellcheck warnings and notes identified by running
shellcheck --severity=style.

Signed-off-by: Fabiano Fidêncio <ffidencio@nvidia.com>
This commit is contained in:
Fabiano Fidêncio
2026-04-21 18:38:02 +02:00
parent 4ab8e58b2b
commit 483407b216
1 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tools/osbuilder/rootfs-builder/ubuntu/rootfs_lib.sh
View File

@@ -11,31 +11,33 @@ build_rootfs() {
# E: Can't find a source to download version '2021.03.26' of 'ubuntu-keyring:amd64'
apt update
# focal version of mmdebstrap only supports comma separated package lists
if [ "$OS_VERSION" = "focal" ]; then
PACKAGES=$(echo "$PACKAGES" | tr ' ' ',')
EXTRA_PKGS=$(echo "$EXTRA_PKGS" | tr ' ' ',')
# shellcheck disable=SC2154
if [[ "${OS_VERSION}" = "focal" ]]; then
PACKAGES=$(echo "${PACKAGES}" | tr ' ' ',')
EXTRA_PKGS=$(echo "${EXTRA_PKGS}" | tr ' ' ',')
fi
if ! mmdebstrap --mode auto --arch "$DEB_ARCH" --variant required \
--components="$REPO_COMPONENTS" \
--include "$PACKAGES,$EXTRA_PKGS" "$OS_VERSION" "$rootfs_dir" "$REPO_URL"; then
# shellcheck disable=SC2154
if ! mmdebstrap --mode auto --arch "${DEB_ARCH}" --variant required \
--components="${REPO_COMPONENTS}" \
--include "${PACKAGES},${EXTRA_PKGS}" "${OS_VERSION}" "${rootfs_dir}" "${REPO_URL}"; then
echo "ERROR: mmdebstrap failed, cannot proceed" && exit 1
else
echo "INFO: mmdebstrap succeeded"
fi
rm -rf "$rootfs_dir/var/run"
ln -s /run "$rootfs_dir/var/run"
cp --remove-destination /etc/resolv.conf "$rootfs_dir/etc"
rm -rf "${rootfs_dir}/var/run"
ln -s /run "${rootfs_dir}/var/run"
cp --remove-destination /etc/resolv.conf "${rootfs_dir}/etc"
local dir="$rootfs_dir/etc/ssl/certs"
mkdir -p "$dir"
cp --remove-destination /etc/ssl/certs/ca-certificates.crt "$dir"
local dir="${rootfs_dir}/etc/ssl/certs"
mkdir -p "${dir}"
cp --remove-destination /etc/ssl/certs/ca-certificates.crt "${dir}"
# Reduce image size and memory footprint by removing unnecessary files and directories.
rm -rf $rootfs_dir/usr/share/{bash-completion,bug,doc,info,lintian,locale,man,menu,misc,pixmaps,terminfo,zsh}
rm -rf "${rootfs_dir}"/usr/share/{bash-completion,bug,doc,info,lintian,locale,man,menu,misc,pixmaps,terminfo,zsh}
# Minimal set of device nodes needed when AGENT_INIT=yes so that the
# kernel can properly setup stdout/stdin/stderr for us
pushd $rootfs_dir/dev
pushd "${rootfs_dir}/dev" || return
MAKEDEV -v console tty ttyS null zero fd
popd
popd || return
}