github/kata-containers
1
0
Fork 2
mirror of https://github.com/kata-containers/kata-containers.git synced 2026-07-02 07:02:16 +00:00
Code Issues Projects Releases Wiki Activity

runtime-rs: use proper temp dirs in initdata tests

Browse Source 
The test currently uses a static directory at `/tmp/initimg_test`. This
introduces non-determinism into the unit test:

* Files that already exist in that dir might alter test results.
* If the directory is owned by root, the test will fail due to
  permissions.

Switch to using the tempfile crate instead.

Fixes: #13053

Signed-off-by: Markus Rudy <mr@edgeless.systems>
This commit is contained in:
Markus Rudy
2026-05-16 20:39:13 +02:00
parent 8e1d73a4b5
commit 4d0f32ce41
1 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/runtime-rs/crates/resource/src/coco_data/initdata_block.rs
View File

@@ -279,16 +279,10 @@ mod tests {
use std::env;
use std::io::Read;
fn setup_test_env() -> PathBuf {
let dir = env::temp_dir().join("initimg_test");
fs::create_dir_all(&dir).unwrap();
dir
}
#[test]
fn test_valid_creation() {
let dir = setup_test_env();
let path = dir.join("test.img");
let dir = tempfile::tempdir().expect("crating temp dir failed");
let path = dir.path().join("test.img");
let data = "[config]\nkey = \"value\"\n";
let result = create_compressed_block(data, &path, Some(6));
@@ -312,8 +306,8 @@ mod tests {
#[test]
fn test_empty_input() {
let dir = setup_test_env();
let path = dir.join("empty.img");
let dir = tempfile::tempdir().expect("crating temp dir failed");
let path = dir.path().join("empty.img");
let result = create_compressed_block("", &path, None);
@@ -326,13 +320,13 @@ mod tests {
#[test]
fn test_different_compression_levels() {
let dir = setup_test_env();
let dir = tempfile::tempdir().expect("crating temp dir failed");
let data = "[config]\n".repeat(1000); // Generate large test data
let sizes = vec![0, 3, 9]
.into_iter()
.map(|level| {
let path = dir.join(format!("test_comp_{}.img", level));
let path = dir.path().join(format!("test_comp_{}.img", level));
let res = create_compressed_block(&data, &path, Some(level));
let size = res.unwrap();
fs::remove_file(&path).unwrap();