github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-07-05 19:47:53 +00:00
Code Issues Projects Releases Wiki Activity

ci: Unify character for separating items

Browse Source 
the test names are using `;` and regexps were designed to use `,` but
during development simply joined the expressions by `|`. This should
work but might be confusing so let's go with the semi-colon separator
everywhere.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
This commit is contained in:
Lukáš Doktor 2024-07-18 13:05:51 +02:00
parent fdcfac0641
commit dd2878a9c8
No known key found for this signature in database
GPG Key ID: 26B362E47FCF22C1
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/testing/gatekeeper/jobs.py
View File

@ -45,7 +45,7 @@ class Checker:
self.latest_commit_sha = os.getenv("COMMIT_HASH") self.latest_commit_sha = os.getenv("COMMIT_HASH")
required_jobs = os.getenv("REQUIRED_JOBS") required_jobs = os.getenv("REQUIRED_JOBS")
if required_jobs: if required_jobs:
required_jobs = required_jobs.split(",") required_jobs = required_jobs.split(";")
else: else:
required_jobs = [] required_jobs = []
required_regexps = os.getenv("REQUIRED_REGEXPS") required_regexps = os.getenv("REQUIRED_REGEXPS")
@ -53,7 +53,7 @@ class Checker:
# TODO: Add way to specify minimum amount of tests # TODO: Add way to specify minimum amount of tests
# (eg. via \d+: prefix) and check it in status # (eg. via \d+: prefix) and check it in status
if required_regexps: if required_regexps:
for regexp in required_regexps.split(","): for regexp in required_regexps.split(";"):
self.required_regexps.append(re.compile(regexp)) self.required_regexps.append(re.compile(regexp))
if not required_jobs and not self.required_regexps: if not required_jobs and not self.required_regexps:
raise RuntimeError("No REQUIRED_JOBS or REQUIRED_REGEXPS defined") raise RuntimeError("No REQUIRED_JOBS or REQUIRED_REGEXPS defined")

2
tools/testing/gatekeeper/skips.py
View File

@ -66,7 +66,7 @@ class Checks:
if values.get("regexps"): if values.get("regexps"):
required_regexps.add(values["regexps"]) required_regexps.add(values["regexps"])
print(';'.join(required_tests)) print(';'.join(required_tests))
print('|'.join(required_regexps)) print(';'.join(required_regexps))
return 0 return 0
def get_features(self, target_branch): def get_features(self, target_branch):