Merge pull request #2750 from liubin/fix/2749-remove-fixme

runtime: set tags for trace span
This commit is contained in:
Bin Liu 2021-10-29 11:42:49 +08:00 committed by GitHub
commit eb248b0c66
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -35,11 +35,8 @@ func hookLogger() *logrus.Entry {
func runHook(ctx context.Context, hook specs.Hook, cid, bundlePath string) error {
span, _ := katatrace.Trace(ctx, hookLogger(), "runHook", hookTracingTags)
defer span.End()
// FIXME
// span.LogFields(
// log.String("hook-name", hook.Path),
// log.String("hook-args", strings.Join(hook.Args, " ")))
katatrace.AddTag(span, "path", hook.Path)
katatrace.AddTag(span, "args", hook.Args)
state := specs.State{
Pid: syscall.Gettid(),