github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-06-28 16:27:50 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2750 from liubin/fix/2749-remove-fixme

Browse Source 
runtime: set tags for trace span
This commit is contained in:
Bin Liu 2021-10-29 11:42:49 +08:00 committed by GitHub
commit eb248b0c66
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/runtime/pkg/katautils/hook.go
View File

@ -35,11 +35,8 @@ func hookLogger() *logrus.Entry {
func runHook(ctx context.Context, hook specs.Hook, cid, bundlePath string) error { func runHook(ctx context.Context, hook specs.Hook, cid, bundlePath string) error {
span, _ := katatrace.Trace(ctx, hookLogger(), "runHook", hookTracingTags) span, _ := katatrace.Trace(ctx, hookLogger(), "runHook", hookTracingTags)
defer span.End() defer span.End()
katatrace.AddTag(span, "path", hook.Path)
// FIXME katatrace.AddTag(span, "args", hook.Args)
// span.LogFields(
// log.String("hook-name", hook.Path),
// log.String("hook-args", strings.Join(hook.Args, " ")))
state := specs.State{ state := specs.State{
Pid: syscall.Gettid(), Pid: syscall.Gettid(),