github/kata-containers
1
0
Fork 2
mirror of https://github.com/kata-containers/kata-containers.git synced 2026-07-25 14:18:54 +00:00
Code Issues Projects Releases Wiki Activity

qemu/machine/tests: document Phase 4/5 placeholder test bodies

Browse Source 
grace_4_gpu_and_nic: state explicitly that HostTopology cannot
represent NIC passthrough yet and that Phase 4 rewrites the body;
the fixture already defines the full expected output.

grace_5_vcmdq: expand the body to call with_hugepages() before
emission, documenting the step Config 5 requires.  The method is a
stub until Phase 5, so the test stays ignored, but the body now
matches the shape Phase 5 lands.

Assisted-by: Claude <noreply@anthropic.com>
Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
This commit is contained in:
Zvonko Kaiser
2026-07-17 17:47:37 +00:00
parent 089fcf6b4e
commit f53be5d1e8
1 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/runtime-rs/crates/hypervisor/src/qemu/machine/tests.rs
View File

@@ -112,8 +112,11 @@ fn grace_3_four_gpus_2_per_smmu() {
#[test]
#[ignore = "Phase 4"]
fn grace_4_gpu_and_nic() {
// NIC is represented differently; exact HostTopology shape TBD in Phase 4.
// Fixture defines the expected output; this test drives the API design.
// Placeholder until Phase 4: HostTopology cannot represent NIC passthrough
// yet, so this topology covers only the GPU half and the test stays
// ignored. Phase 4 adds nic_smmu_groups and rewrites this body; the
// fixture already defines the full expected output (GPU on pcie.1, NIC on
// pcie.2 with no acpi-generic-initiator links).
check(
HostTopology {
sockets: single_socket(0..4),
@@ -129,14 +132,22 @@ fn grace_4_gpu_and_nic() {
#[test]
#[ignore = "Phase 5"]
fn grace_5_vcmdq() {
check(
HostTopology {
sockets: single_socket(0..4),
gpu_smmu_groups: smmu_groups(&[&["0008:06:00.0"]], 0),
egm_sockets: vec![],
},
"grace_5_vcmdq.args",
);
// Config 5 backs guest RAM with hugepages: with_hugepages() swaps the
// primary backend to mem-path=/dev/hugepages/ with prealloc=on before
// emission. The call is a stub until Phase 5 implements it, so the test
// stays ignored, but the body already documents the required step.
let topo = HostTopology {
sockets: single_socket(0..4),
gpu_smmu_groups: smmu_groups(&[&["0008:06:00.0"]], 0),
egm_sockets: vec![],
};
let mut platform =
Platform::from_config_defaults(16 << 30).expect("Platform::from_config_defaults");
platform.apply_host_defaults(&topo);
let platform = platform.with_hugepages("/dev/hugepages/");
let got = platform.to_qemu_args().expect("to_qemu_args");
let want = load_fixture("grace_5_vcmdq.args");
assert_eq!(want, got);
}
// ---- Grace Config 6: vEGM, 1 GPU per socket, 4 sockets ----