mirror of
https://github.com/ahmetb/kubectx.git
synced 2026-03-11 16:32:19 +00:00
Compare commits
1 Commits
master
...
abalkan/xd
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
ec39a19beb |
@@ -52,14 +52,6 @@ func (op InteractiveSwitchOp) Run(_, stderr io.Writer) error {
|
||||
return fmt.Errorf("kubeconfig error: %w", err)
|
||||
}
|
||||
|
||||
ctxNames, err := kc.ContextNames()
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to get context names: %w", err)
|
||||
}
|
||||
if len(ctxNames) == 0 {
|
||||
return errors.New("no contexts found in the kubeconfig file")
|
||||
}
|
||||
|
||||
cmd := exec.Command("fzf", "--ansi", "--no-preview")
|
||||
var out bytes.Buffer
|
||||
cmd.Stdin = os.Stdin
|
||||
|
||||
@@ -46,14 +46,6 @@ func (op InteractiveSwitchOp) Run(_, stderr io.Writer) error {
|
||||
return fmt.Errorf("kubeconfig error: %w", err)
|
||||
}
|
||||
|
||||
ctxNames, err := kc.ContextNames()
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to get context names: %w", err)
|
||||
}
|
||||
if len(ctxNames) == 0 {
|
||||
return errors.New("no contexts found in the kubeconfig file")
|
||||
}
|
||||
|
||||
cmd := exec.Command("fzf", "--ansi", "--no-preview")
|
||||
var out bytes.Buffer
|
||||
cmd.Stdin = os.Stdin
|
||||
|
||||
@@ -18,6 +18,8 @@ import (
|
||||
"runtime"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/ahmetb/kubectx/internal/testutil"
|
||||
)
|
||||
|
||||
func TestNSFile(t *testing.T) {
|
||||
@@ -48,7 +50,7 @@ func TestNSFile(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestNSFile_path_windows(t *testing.T) {
|
||||
t.Setenv("_FORCE_GOOS", "windows")
|
||||
defer testutil.WithEnvVar("_FORCE_GOOS", "windows")()
|
||||
fp := NewNSFile("a:b:c").path()
|
||||
|
||||
if expected := "a__b__c"; !strings.HasSuffix(fp, expected) {
|
||||
@@ -66,7 +68,7 @@ func Test_isWindows(t *testing.T) {
|
||||
t.Fatalf("isWindows() returned true for %s", runtime.GOOS)
|
||||
}
|
||||
|
||||
t.Setenv("_FORCE_GOOS", "windows")
|
||||
defer testutil.WithEnvVar("_FORCE_GOOS", "windows")()
|
||||
if !isWindows() {
|
||||
t.Fatalf("isWindows() failed to detect windows with env override.")
|
||||
}
|
||||
|
||||
@@ -17,6 +17,8 @@ package cmdutil
|
||||
import (
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
"github.com/ahmetb/kubectx/internal/testutil"
|
||||
)
|
||||
|
||||
func Test_homeDir(t *testing.T) {
|
||||
@@ -62,14 +64,18 @@ func Test_homeDir(t *testing.T) {
|
||||
|
||||
for _, c := range cases {
|
||||
t.Run(c.name, func(tt *testing.T) {
|
||||
var unsets []func()
|
||||
for _, e := range c.envs {
|
||||
tt.Setenv(e.k, e.v)
|
||||
unsets = append(unsets, testutil.WithEnvVar(e.k, e.v))
|
||||
}
|
||||
|
||||
got := HomeDir()
|
||||
if got != c.want {
|
||||
t.Errorf("expected:%q got:%q", c.want, got)
|
||||
}
|
||||
for _, u := range unsets {
|
||||
u()
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
@@ -15,16 +15,17 @@
|
||||
package kubeconfig
|
||||
|
||||
import (
|
||||
"github.com/ahmetb/kubectx/internal/cmdutil"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/ahmetb/kubectx/internal/cmdutil"
|
||||
"github.com/ahmetb/kubectx/internal/testutil"
|
||||
)
|
||||
|
||||
func Test_kubeconfigPath(t *testing.T) {
|
||||
t.Setenv("HOME", "/x/y/z")
|
||||
defer testutil.WithEnvVar("HOME", "/x/y/z")()
|
||||
|
||||
expected := filepath.FromSlash("/x/y/z/.kube/config")
|
||||
got, err := kubeconfigPath()
|
||||
@@ -37,9 +38,9 @@ func Test_kubeconfigPath(t *testing.T) {
|
||||
}
|
||||
|
||||
func Test_kubeconfigPath_noEnvVars(t *testing.T) {
|
||||
t.Setenv("XDG_CACHE_HOME", "")
|
||||
t.Setenv("HOME", "")
|
||||
t.Setenv("USERPROFILE", "")
|
||||
defer testutil.WithEnvVar("XDG_CACHE_HOME", "")()
|
||||
defer testutil.WithEnvVar("HOME", "")()
|
||||
defer testutil.WithEnvVar("USERPROFILE", "")()
|
||||
|
||||
_, err := kubeconfigPath()
|
||||
if err == nil {
|
||||
@@ -48,7 +49,7 @@ func Test_kubeconfigPath_noEnvVars(t *testing.T) {
|
||||
}
|
||||
|
||||
func Test_kubeconfigPath_envOvveride(t *testing.T) {
|
||||
t.Setenv("KUBECONFIG", "foo")
|
||||
defer testutil.WithEnvVar("KUBECONFIG", "foo")()
|
||||
|
||||
v, err := kubeconfigPath()
|
||||
if err != nil {
|
||||
@@ -61,7 +62,7 @@ func Test_kubeconfigPath_envOvveride(t *testing.T) {
|
||||
|
||||
func Test_kubeconfigPath_envOvverideDoesNotSupportPathSeparator(t *testing.T) {
|
||||
path := strings.Join([]string{"file1", "file2"}, string(os.PathListSeparator))
|
||||
t.Setenv("KUBECONFIG", path)
|
||||
defer testutil.WithEnvVar("KUBECONFIG", path)()
|
||||
|
||||
_, err := kubeconfigPath()
|
||||
if err == nil {
|
||||
@@ -70,7 +71,7 @@ func Test_kubeconfigPath_envOvverideDoesNotSupportPathSeparator(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestStandardKubeconfigLoader_returnsNotFoundErr(t *testing.T) {
|
||||
t.Setenv("KUBECONFIG", "foo")
|
||||
defer testutil.WithEnvVar("KUBECONFIG", "foo")()
|
||||
kc := new(Kubeconfig).WithLoader(DefaultLoader)
|
||||
err := kc.Parse()
|
||||
if err == nil {
|
||||
|
||||
@@ -18,6 +18,8 @@ import (
|
||||
"testing"
|
||||
|
||||
"github.com/google/go-cmp/cmp"
|
||||
|
||||
"github.com/ahmetb/kubectx/internal/testutil"
|
||||
)
|
||||
|
||||
var (
|
||||
@@ -25,8 +27,8 @@ var (
|
||||
)
|
||||
|
||||
func Test_useColors_forceColors(t *testing.T) {
|
||||
t.Setenv("_KUBECTX_FORCE_COLOR", "1")
|
||||
t.Setenv("NO_COLOR", "1")
|
||||
defer testutil.WithEnvVar("_KUBECTX_FORCE_COLOR", "1")()
|
||||
defer testutil.WithEnvVar("NO_COLOR", "1")()
|
||||
|
||||
if v := useColors(); !cmp.Equal(v, &tr) {
|
||||
t.Fatalf("expected useColors() = true; got = %v", v)
|
||||
@@ -34,7 +36,7 @@ func Test_useColors_forceColors(t *testing.T) {
|
||||
}
|
||||
|
||||
func Test_useColors_disableColors(t *testing.T) {
|
||||
t.Setenv("NO_COLOR", "1")
|
||||
defer testutil.WithEnvVar("NO_COLOR", "1")()
|
||||
|
||||
if v := useColors(); !cmp.Equal(v, &fa) {
|
||||
t.Fatalf("expected useColors() = false; got = %v", v)
|
||||
@@ -42,8 +44,8 @@ func Test_useColors_disableColors(t *testing.T) {
|
||||
}
|
||||
|
||||
func Test_useColors_default(t *testing.T) {
|
||||
t.Setenv("NO_COLOR", "")
|
||||
t.Setenv("_KUBECTX_FORCE_COLOR", "")
|
||||
defer testutil.WithEnvVar("NO_COLOR", "")()
|
||||
defer testutil.WithEnvVar("_KUBECTX_FORCE_COLOR", "")()
|
||||
|
||||
if v := useColors(); v != nil {
|
||||
t.Fatalf("expected useColors() = nil; got=%v", *v)
|
||||
|
||||
31
internal/testutil/testutil.go
Normal file
31
internal/testutil/testutil.go
Normal file
@@ -0,0 +1,31 @@
|
||||
// Copyright 2021 Google LLC
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
|
||||
package testutil
|
||||
|
||||
import "os"
|
||||
|
||||
// WithEnvVar sets an env var temporarily. Call its return value
|
||||
// in defer to restore original value in env (if exists).
|
||||
func WithEnvVar(key, value string) func() {
|
||||
orig, ok := os.LookupEnv(key)
|
||||
os.Setenv(key, value)
|
||||
return func() {
|
||||
if ok {
|
||||
os.Setenv(key, orig)
|
||||
} else {
|
||||
os.Unsetenv(key)
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user