mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-23 19:56:01 +00:00
Improve pathrecorder duplicate registration info
Print information from both the original path registration and the new path registration stack traces when encountering a duplicate. This helps the developer determine where the duplication is coming from and makes it much easier to resolve. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
This commit is contained in:
parent
2daa3415ec
commit
04aa8f9dcd
@ -103,10 +103,11 @@ func (m *PathRecorderMux) ListedPaths() []string {
|
||||
}
|
||||
|
||||
func (m *PathRecorderMux) trackCallers(path string) {
|
||||
stack := string(debug.Stack())
|
||||
if existingStack, ok := m.pathStacks[path]; ok {
|
||||
utilruntime.HandleError(fmt.Errorf("registered %q from %v", path, existingStack))
|
||||
utilruntime.HandleError(fmt.Errorf("duplicate path registration of %q: original registration from %v\n\nnew registration from %v", path, existingStack, stack))
|
||||
}
|
||||
m.pathStacks[path] = string(debug.Stack())
|
||||
m.pathStacks[path] = stack
|
||||
}
|
||||
|
||||
// refreshMuxLocked creates a new mux and must be called while locked. Otherwise the view of handlers may
|
||||
|
Loading…
Reference in New Issue
Block a user