mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-22 19:31:44 +00:00
Merge pull request #114683 from thockin/remove_old_comment_proxy_valid_pod_addr
Remove TODO about API proxy checking for svc
This commit is contained in:
commit
05ecc3d602
@ -464,7 +464,7 @@ func (r *REST) ResourceLocation(ctx context.Context, id string) (*url.URL, http.
|
|||||||
// but in the expected case we'll only make one.
|
// but in the expected case we'll only make one.
|
||||||
for try := 0; try < len(ss.Addresses); try++ {
|
for try := 0; try < len(ss.Addresses); try++ {
|
||||||
addr := ss.Addresses[(addrSeed+try)%len(ss.Addresses)]
|
addr := ss.Addresses[(addrSeed+try)%len(ss.Addresses)]
|
||||||
// TODO(thockin): do we really need this check?
|
// We only proxy to addresses that are actually pods.
|
||||||
if err := isValidAddress(ctx, &addr, r.pods); err != nil {
|
if err := isValidAddress(ctx, &addr, r.pods); err != nil {
|
||||||
utilruntime.HandleError(fmt.Errorf("Address %v isn't valid (%v)", addr, err))
|
utilruntime.HandleError(fmt.Errorf("Address %v isn't valid (%v)", addr, err))
|
||||||
continue
|
continue
|
||||||
|
Loading…
Reference in New Issue
Block a user