github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 15:05:27 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #114683 from thockin/remove_old_comment_proxy_valid_pod_addr

Browse Source 
Remove TODO about API proxy checking for svc
This commit is contained in:
Kubernetes Prow Robot 2022-12-23 15:37:37 -08:00 committed by GitHub
commit 05ecc3d602
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/registry/core/service/storage/storage.go
View File

@ -464,7 +464,7 @@ func (r *REST) ResourceLocation(ctx context.Context, id string) (*url.URL, http.
// but in the expected case we'll only make one. // but in the expected case we'll only make one.
for try := 0; try < len(ss.Addresses); try++ { for try := 0; try < len(ss.Addresses); try++ {
addr := ss.Addresses[(addrSeed+try)%len(ss.Addresses)] addr := ss.Addresses[(addrSeed+try)%len(ss.Addresses)]
// TODO(thockin): do we really need this check? // We only proxy to addresses that are actually pods.
if err := isValidAddress(ctx, &addr, r.pods); err != nil { if err := isValidAddress(ctx, &addr, r.pods); err != nil {
utilruntime.HandleError(fmt.Errorf("Address %v isn't valid (%v)", addr, err)) utilruntime.HandleError(fmt.Errorf("Address %v isn't valid (%v)", addr, err))
continue continue