Merge pull request #67108 from yujuhong/crictl-test

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

GCE: add a crictl test

This verifies that crictl is available on the node.



**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

test/e2e/node/BUILD

@@ -4,6 +4,7 @@ go_library(
     name = "go_default_library",
     srcs = [
         "apparmor.go",
+        "crictl.go",
         "events.go",
         "framework.go",
         "kubelet.go",

test/e2e/node/crictl.go

@@ -0,0 +1,73 @@
+/*
+Copyright 2018 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package node
+
+import (
+	"fmt"
+	"strings"
+
+	"k8s.io/kubernetes/test/e2e/framework"
+
+	. "github.com/onsi/ginkgo"
+)
+
+var _ = SIGDescribe("crictl", func() {
+	f := framework.NewDefaultFramework("crictl")
+
+	BeforeEach(func() {
+		// `crictl` is not available on all cloud providers.
+		framework.SkipUnlessProviderIs("gce", "gke")
+		// The test requires $HOME/.ssh/id_rsa key to be present.
+		framework.SkipUnlessSSHKeyPresent()
+	})
+
+	It("should be able to run crictl on the node", func() {
+		// Get all nodes' external IPs.
+		By("Getting all nodes' SSH-able IP addresses")
+		hosts, err := framework.NodeSSHHosts(f.ClientSet)
+		if err != nil {
+			framework.Failf("Error getting node hostnames: %v", err)
+		}
+
+		testCases := []struct {
+			cmd string
+		}{
+			{`sudo crictl version`},
+			{`sudo crictl info`},
+		}
+
+		for _, testCase := range testCases {
+			// Choose an arbitrary node to test.
+			host := hosts[0]
+			By(fmt.Sprintf("SSH'ing to node %q to run %q", host, testCase.cmd))
+
+			result, err := framework.SSH(testCase.cmd, host, framework.TestContext.Provider)
+			stdout, stderr := strings.TrimSpace(result.Stdout), strings.TrimSpace(result.Stderr)
+			if err != nil {
+				framework.Failf("Ran %q on %q, got error %v", testCase.cmd, host, err)
+			}
+			// Log the stdout/stderr output.
+			// TODO: Verify the output.
+			if len(stdout) > 0 {
+				framework.Logf("Got stdout from %q:\n %s\n", host, strings.TrimSpace(stdout))
+			}
+			if len(stderr) > 0 {
+				framework.Logf("Got stderr from %q:\n %s\n", host, strings.TrimSpace(stderr))
+			}
+		}
+	})
+})