mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-25 04:33:26 +00:00
pkg/kubelet/userns: Remove skip on windows
We don't build these tests for Windows, let's remove this skip. We should have never added that skip, we should have skipped the entire suite on Windows. Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
This commit is contained in:
parent
1d923fbc78
commit
07011c05b7
@ -23,7 +23,6 @@ import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
goruntime "runtime"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
@ -292,7 +291,6 @@ func TestGetOrCreateUserNamespaceMappings(t *testing.T) {
|
||||
runtimeUserns bool
|
||||
runtimeHandler string
|
||||
success bool
|
||||
skipOnWindows bool
|
||||
}{
|
||||
{
|
||||
name: "no user namespace",
|
||||
@ -326,7 +324,6 @@ func TestGetOrCreateUserNamespaceMappings(t *testing.T) {
|
||||
expMode: runtimeapi.NamespaceMode_POD,
|
||||
runtimeUserns: true,
|
||||
success: true,
|
||||
skipOnWindows: true,
|
||||
},
|
||||
{
|
||||
name: "user namespace, but no runtime support",
|
||||
@ -351,10 +348,6 @@ func TestGetOrCreateUserNamespaceMappings(t *testing.T) {
|
||||
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
if tc.skipOnWindows && goruntime.GOOS == "windows" {
|
||||
// TODO: remove skip once the failing test has been fixed.
|
||||
t.Skip("Skip failing test on Windows.")
|
||||
}
|
||||
// These tests will create the userns file, so use an existing podDir.
|
||||
testUserNsPodsManager := &testUserNsPodsManager{
|
||||
podDir: t.TempDir(),
|
||||
|
Loading…
Reference in New Issue
Block a user