github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-20 18:31:15 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #50607 from lukaszo/logdns

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 50531, 50853, 49976, 50939, 50607)

Log error from ensureDNSRecords

Hiding errors is not a good idea. It took me some time to figure it out why my coredns is not working. It turned out that I had wrong etcd configuration but errors about it were hidden.

```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2017-08-21 15:46:24 -07:00 committed by GitHub
commit 078a3b653b
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
federation/pkg/federation-controller/service/dns/dns.go
View File

@ -182,6 +182,7 @@ func (s *ServiceDNSController) workerFunction() bool {
for _, clusterIngress := range ingress.Items {
err = s.ensureDNSRecords(clusterIngress.Cluster, service)
if err != nil {
runtime.HandleError(fmt.Errorf("Error when ensuring DNS records for service %s/%s: %v", service.Namespace, service.Name, err))
s.deliverService(service, 0, true)
}
}