github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-14 21:53:52 +00:00
Code Issues Projects Releases Wiki Activity

remove useless check from impersonation filter

Browse Source 
When groupsSpecified is false, that means no other groups are added
rather than the service account groups. So this check doesn't make
any sense.
This commit is contained in:
Cao Shufeng
2017-06-30 10:51:07 +08:00
parent 956acc2bd8
commit 0a1e24f31e
1 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
staging/src/k8s.io/apiserver/pkg/endpoints/filters/impersonation.go
View File

@@ -118,18 +118,8 @@ func WithImpersonation(handler http.Handler, requestContextMapper request.Reques
if !groupsSpecified && username != user.Anonymous {
// When impersonating a non-anonymous user, if no groups were specified
// if neither the system:authenticated nor system:unauthenticated groups are explicitly included,
// include the system:authenticated group in the impersonated user info
found := false
for _, group := range groups {
if group == user.AllAuthenticated || group == user.AllUnauthenticated {
found = true
break
}
}
if !found {
groups = append(groups, user.AllAuthenticated)
}
groups = append(groups, user.AllAuthenticated)
}
newUser := &user.DefaultInfo{