github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 15:25:57 +00:00
Code Issues Projects Releases Wiki Activity

If no tag was specified, pull "latest" explicitly.

Browse Source 
When no tag is given to Docker pull, it downloads all tags. This could be a
significantly large number of images and in the end we only ever run
:latest.
This commit is contained in:
Victor Marmol 2014-07-20 10:31:26 -07:00
parent 3398646170
commit 0a2b1bf644
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/kubelet/docker.go
View File

@ -65,6 +65,12 @@ func NewDockerPuller(client DockerInterface) DockerPuller {
func (p dockerPuller) Pull(image string) error {
image, tag := parseImageName(image)
// If no tag was specified, use the default "latest".
if len(tag) == 0 {
tag = "latest"
}
opts := docker.PullImageOptions{
Repository: image,
Tag: tag,
@ -194,7 +200,7 @@ func parseDockerName(name string) (manifestID, containerName string) {
return
}
// Parses image name including an tag and returns image name and tag
// Parses image name including a tag and returns image name and tag.
// TODO: Future Docker versions can parse the tag on daemon side, see:
// https://github.com/dotcloud/docker/issues/6876
// So this can be deprecated at some point.