github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-25 03:21:15 +00:00
Code Issues Projects Releases Wiki Activity

Remove obviously redundant tests

Browse Source
This commit is contained in:
Tim Hockin 2023-03-03 11:56:25 -08:00 committed by Alexander Constantinescu
parent f56e62ca14
commit 0ccab9804a
1 changed files with 11 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
View File

@ -2150,6 +2150,17 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
shouldSync bool shouldSync bool
stableNodeSetEnabled bool stableNodeSetEnabled bool
}{{ }{{
name: "nothing changed",
oldNode: makeNode(),
newNode: makeNode(),
shouldSync: false,
}, {
name: "nothing changed",
oldNode: makeNode(),
newNode: makeNode(),
shouldSync: false,
stableNodeSetEnabled: true,
}, {
name: "taint F->T", name: "taint F->T",
oldNode: makeNode(), oldNode: makeNode(),
newNode: makeNode(tweakAddTaint(ToBeDeletedTaint)), newNode: makeNode(tweakAddTaint(ToBeDeletedTaint)),
@ -2159,11 +2170,6 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
oldNode: makeNode(tweakAddTaint(ToBeDeletedTaint)), oldNode: makeNode(tweakAddTaint(ToBeDeletedTaint)),
newNode: makeNode(), newNode: makeNode(),
shouldSync: true, shouldSync: true,
}, {
name: "taint F->F",
oldNode: makeNode(),
newNode: makeNode(),
shouldSync: false,
}, { }, {
name: "taint T->T", name: "taint T->T",
oldNode: makeNode(tweakAddTaint(ToBeDeletedTaint)), oldNode: makeNode(tweakAddTaint(ToBeDeletedTaint)),
@ -2194,11 +2200,6 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
oldNode: makeNode(tweakSetLabel(v1.LabelNodeExcludeBalancers, "")), oldNode: makeNode(tweakSetLabel(v1.LabelNodeExcludeBalancers, "")),
newNode: makeNode(tweakSetLabel(v1.LabelNodeExcludeBalancers, "")), newNode: makeNode(tweakSetLabel(v1.LabelNodeExcludeBalancers, "")),
shouldSync: false, shouldSync: false,
}, {
name: "excluded changed F->F",
oldNode: makeNode(),
newNode: makeNode(),
shouldSync: false,
}, { }, {
name: "excluded F->T", name: "excluded F->T",
oldNode: makeNode(), oldNode: makeNode(),
@ -2217,12 +2218,6 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
newNode: makeNode(tweakSetLabel(v1.LabelNodeExcludeBalancers, "")), newNode: makeNode(tweakSetLabel(v1.LabelNodeExcludeBalancers, "")),
shouldSync: false, shouldSync: false,
stableNodeSetEnabled: true, stableNodeSetEnabled: true,
}, {
name: "excluded changed F->F",
oldNode: makeNode(),
newNode: makeNode(),
shouldSync: false,
stableNodeSetEnabled: true,
}, { }, {
name: "other label changed F->T", name: "other label changed F->T",
oldNode: makeNode(), oldNode: makeNode(),
@ -2243,11 +2238,6 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
oldNode: makeNode(), oldNode: makeNode(),
newNode: makeNode(tweakSetReady(false)), newNode: makeNode(tweakSetReady(false)),
shouldSync: true, shouldSync: true,
}, {
name: "readiness changed T->T",
oldNode: makeNode(),
newNode: makeNode(),
shouldSync: false,
}, { }, {
name: "readiness changed F->F", name: "readiness changed F->F",
oldNode: makeNode(tweakSetReady(false)), oldNode: makeNode(tweakSetReady(false)),