github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 22:46:12 +00:00
Code Issues Projects Releases Wiki Activity

DRA resourceslice controller: do DeepCopy for driver resources

Browse Source 
The reason for the previous behavior was unnecessary performance overhead that
occurs when the caller already provided a "fresh" copy and doesn't touch it
afterwards.

But this is something that DRA driver developers can easily get wrong, so it's
better to be safe than sorry.
This commit is contained in:
Patrick Ohly 2024-10-30 11:48:53 +01:00
parent 67f0428769
commit 1088f4fb44
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
staging/src/k8s.io/dynamic-resource-allocation/resourceslice/resourceslicecontroller.go
View File

@ -191,9 +191,7 @@ type Options struct {
// a driver uninstall because garbage collection won't work.
Owner *Owner
// This is the initial desired set of slices. As with
// [Controller.Update], the controller takes ownership of the resources
// instance. The content must not get modified by the caller.
// This is the initial desired set of slices.
Resources *DriverResources
// Queue can be used to override the default work queue implementation.
@ -224,9 +222,8 @@ func (c *Controller) Stop() {
// Update sets the new desired state of the resource information.
//
// The controller takes over ownership, so these resources must
// not get modified after this method returns. [DriverResources.DeepCopy]
// can be used by the caller to clone some existing instance.
// The controller is doing a deep copy, so the caller may update
// the instance once Update returns.
func (c *Controller) Update(resources *DriverResources) {
c.mutex.Lock()
defer c.mutex.Unlock()
@ -236,7 +233,7 @@ func (c *Controller) Update(resources *DriverResources) {
c.queue.Add(poolName)
}
c.resources = resources
c.resources = resources.DeepCopy()
// ... and the new ones (might be the same).
for poolName := range c.resources.Pools {
@ -283,7 +280,7 @@ func newController(ctx context.Context, options Options) (*Controller, error) {
driverName: options.DriverName,
owner: options.Owner.DeepCopy(),
queue: options.Queue,
resources: options.Resources,
resources: options.Resources.DeepCopy(),
mutationCacheTTL: ptr.Deref(options.MutationCacheTTL, defaultMutationCacheTTL),
syncDelay: ptr.Deref(options.SyncDelay, defaultSyncDelay),
}