Merge pull request #130127 from carlory/fix-metrics

GetRandomReadySchedulableNode does not return MetricsGrabbingDisabledError
This commit is contained in:
Kubernetes Prow Robot 2025-02-13 00:12:20 -08:00 committed by GitHub
commit 11ec99f7ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -59,12 +59,12 @@ var _ = common.SIGDescribe("Metrics", func() {
ginkgo.It("should grab all metrics from kubelet /metrics/resource endpoint", func(ctx context.Context) {
ginkgo.By("Connecting to kubelet's /metrics/resource endpoint")
node, err := e2enode.GetRandomReadySchedulableNode(ctx, f.ClientSet)
framework.ExpectNoError(err)
response, err := grabber.GrabResourceMetricsFromKubelet(ctx, node.Name)
if errors.Is(err, e2emetrics.MetricsGrabbingDisabledError) {
e2eskipper.Skipf("%v", err)
}
framework.ExpectNoError(err)
response, err := grabber.GrabResourceMetricsFromKubelet(ctx, node.Name)
framework.ExpectNoError(err)
gomega.Expect(response).NotTo(gomega.BeEmpty())
})
})