github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 14:37:00 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #31054 from tmrts/docs/gh-pr-warning

Browse Source 
Automatic merge from submit-queue

docs/devel: document the behavior of github UI for PRs

Documents the problem encountered in #30596

cc @bgrant0607 @thockin @roberthbailey
This commit is contained in:
Kubernetes Submit Queue 2016-08-20 15:37:05 -07:00 committed by GitHub
commit 13c8be67a6
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/devel/development.md
View File

@ -225,6 +225,8 @@ git push -f origin my-feature
2. Click the "Compare & pull request" button next to your "my-feature" branch.
3. Check out the pull request [process](pull-requests.md) for more details
**Note:** If you have write access, please refrain from using the GitHub UI for creating PRs, because GitHub will create the PR branch inside the main repository rather than inside your fork.
### When to retain commits and when to squash
Upon merge, all git commits should represent meaningful milestones or units of