github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 15:05:27 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #95099 from brianpursley/TestReadLogs

Browse Source 
Added unit tests for ReadLogs
This commit is contained in:
Kubernetes Prow Robot 2020-12-08 16:29:02 -08:00 committed by GitHub
commit 1588d58151
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 142 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/kubelet/kuberuntime/logs/BUILD
View File

@ -24,7 +24,9 @@ go_test(
"//staging/src/k8s.io/api/core/v1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
"//staging/src/k8s.io/cri-api/pkg/apis/runtime/v1alpha2:go_default_library",
"//staging/src/k8s.io/cri-api/pkg/apis/testing:go_default_library",
"//vendor/github.com/stretchr/testify/assert:go_default_library",
"//vendor/k8s.io/utils/pointer:go_default_library",
],
)

140
pkg/kubelet/kuberuntime/logs/logs_test.go
View File

@ -18,6 +18,11 @@ package logs
import (
"bytes"
"context"
"io/ioutil"
apitesting "k8s.io/cri-api/pkg/apis/testing"
"k8s.io/utils/pointer"
"os"
"testing"
"time"
@ -66,6 +71,141 @@ func TestLogOptions(t *testing.T) {
}
}
func TestReadLogs(t *testing.T) {
file, err := ioutil.TempFile("", "TestFollowLogs")
if err != nil {
t.Fatalf("unable to create temp file")
}
defer os.Remove(file.Name())
file.WriteString(`{"log":"line1\n","stream":"stdout","time":"2020-09-27T11:18:01.00000000Z"}` + "\n")
file.WriteString(`{"log":"line2\n","stream":"stdout","time":"2020-09-27T11:18:02.00000000Z"}` + "\n")
file.WriteString(`{"log":"line3\n","stream":"stdout","time":"2020-09-27T11:18:03.00000000Z"}` + "\n")
testCases := []struct {
name string
podLogOptions v1.PodLogOptions
expected string
}{
{
name: "default pod log options should output all lines",
podLogOptions: v1.PodLogOptions{},
expected: "line1\nline2\nline3\n",
},
{
name: "using TailLines 2 should output last 2 lines",
podLogOptions: v1.PodLogOptions{
TailLines: pointer.Int64Ptr(2),
},
expected: "line2\nline3\n",
},
{
name: "using TailLines 4 should output all lines when the log has less than 4 lines",
podLogOptions: v1.PodLogOptions{
TailLines: pointer.Int64Ptr(4),
},
expected: "line1\nline2\nline3\n",
},
{
name: "using TailLines 0 should output nothing",
podLogOptions: v1.PodLogOptions{
TailLines: pointer.Int64Ptr(0),
},
expected: "",
},
{
name: "using LimitBytes 9 should output first 9 bytes",
podLogOptions: v1.PodLogOptions{
LimitBytes: pointer.Int64Ptr(9),
},
expected: "line1\nlin",
},
{
name: "using LimitBytes 100 should output all bytes when the log has less than 100 bytes",
podLogOptions: v1.PodLogOptions{
LimitBytes: pointer.Int64Ptr(100),
},
expected: "line1\nline2\nline3\n",
},
{
name: "using LimitBytes 0 should output nothing",
podLogOptions: v1.PodLogOptions{
LimitBytes: pointer.Int64Ptr(0),
},
expected: "",
},
{
name: "using SinceTime should output lines with a time on or after the specified time",
podLogOptions: v1.PodLogOptions{
SinceTime: &metav1.Time{Time: time.Date(2020, time.Month(9), 27, 11, 18, 02, 0, time.UTC)},
},
expected: "line2\nline3\n",
},
{
name: "using SinceTime now should output nothing",
podLogOptions: v1.PodLogOptions{
SinceTime: &metav1.Time{Time: time.Now()},
},
expected: "",
},
{
name: "using follow should output all log lines",
podLogOptions: v1.PodLogOptions{
Follow: true,
},
expected: "line1\nline2\nline3\n",
},
{
name: "using follow combined with TailLines 2 should output the last 2 lines",
podLogOptions: v1.PodLogOptions{
Follow: true,
TailLines: pointer.Int64Ptr(2),
},
expected: "line2\nline3\n",
},
{
name: "using follow combined with SinceTime should output lines with a time on or after the specified time",
podLogOptions: v1.PodLogOptions{
Follow: true,
SinceTime: &metav1.Time{Time: time.Date(2020, time.Month(9), 27, 11, 18, 02, 0, time.UTC)},
},
expected: "line2\nline3\n",
},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
containerID := "fake-container-id"
fakeRuntimeService := &apitesting.FakeRuntimeService{
Containers: map[string]*apitesting.FakeContainer{
containerID: {
ContainerStatus: runtimeapi.ContainerStatus{
State: runtimeapi.ContainerState_CONTAINER_RUNNING,
},
},
},
}
// If follow is specified, mark the container as exited or else ReadLogs will run indefinitely
if tc.podLogOptions.Follow {
fakeRuntimeService.Containers[containerID].State = runtimeapi.ContainerState_CONTAINER_EXITED
}
opts := NewLogOptions(&tc.podLogOptions, time.Now())
stdoutBuf := bytes.NewBuffer(nil)
stderrBuf := bytes.NewBuffer(nil)
err = ReadLogs(context.TODO(), file.Name(), containerID, opts, fakeRuntimeService, stdoutBuf, stderrBuf)
if err != nil {
t.Fatalf(err.Error())
}
if stderrBuf.Len() > 0 {
t.Fatalf("Stderr: %v", stderrBuf.String())
}
if actual := stdoutBuf.String(); tc.expected != actual {
t.Fatalf("Actual output does not match expected.\nActual: %v\nExpected: %v\n", actual, tc.expected)
}
})
}
}
func TestParseLog(t *testing.T) {
timestamp, err := time.Parse(timeFormatIn, "2016-10-20T18:39:20.57606443Z")
assert.NoError(t, err)