github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 05:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #87544 from SenXuDC/staticcheck

Browse Source 
fix static check in pkg/volume/flocker
This commit is contained in:
Kubernetes Prow Robot 2020-01-29 07:32:42 -08:00 committed by GitHub
commit 17936ff63b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hack/.staticcheck_failures
View File

@ -22,7 +22,6 @@ pkg/volume/azure_file
pkg/volume/csi pkg/volume/csi
pkg/volume/fc pkg/volume/fc
pkg/volume/flexvolume pkg/volume/flexvolume
pkg/volume/flocker
pkg/volume/iscsi pkg/volume/iscsi
pkg/volume/local pkg/volume/local
pkg/volume/portworx pkg/volume/portworx

1
pkg/volume/flocker/flocker.go
View File

@ -394,7 +394,6 @@ func (b *flockerVolumeMounter) updateDatasetPrimary(datasetUUID string, primaryU
datasetUUID, primaryUUID, err, datasetUUID, primaryUUID, err,
) )
case <-tickChan.C: case <-tickChan.C:
break
} }
} }

4
pkg/volume/flocker/flocker_volume_test.go
View File

@ -85,7 +85,7 @@ func TestProvision(t *testing.T) {
dir, provisioner = newTestableProvisioner(t, assert, options) dir, provisioner = newTestableProvisioner(t, assert, options)
defer os.RemoveAll(dir) defer os.RemoveAll(dir)
persistentSpec, err = provisioner.Provision(nil, nil) _, err = provisioner.Provision(nil, nil)
assert.Error(err, "Provision() did not fail with Parameters specified") assert.Error(err, "Provision() did not fail with Parameters specified")
// selectors are not supported // selectors are not supported
@ -97,6 +97,6 @@ func TestProvision(t *testing.T) {
dir, provisioner = newTestableProvisioner(t, assert, options) dir, provisioner = newTestableProvisioner(t, assert, options)
defer os.RemoveAll(dir) defer os.RemoveAll(dir)
persistentSpec, err = provisioner.Provision(nil, nil) _, err = provisioner.Provision(nil, nil)
assert.Error(err, "Provision() did not fail with Selector specified") assert.Error(err, "Provision() did not fail with Selector specified")
} }