github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 20:24:09 +00:00
Code Issues Projects Releases Wiki Activity

test(apiserver): deflake TestClientReceivedGOAWAY

Browse Source 
protect `localAddr` from concurrent read and write

Signed-off-by: knight42 <anonymousknight96@gmail.com>
This commit is contained in:
knight42 2020-09-04 23:35:53 +08:00 committed by Jordan Liggitt
parent 6125e6b65a
commit 1f235c858c
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/apiserver/pkg/server/filters/goaway_test.go
View File

@ -342,6 +342,7 @@ func TestClientReceivedGOAWAY(t *testing.T) {
for _, tc := range cases { for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {
var mu sync.Mutex
// localAddr indicates how many TCP connection set up // localAddr indicates how many TCP connection set up
localAddr := make([]string, 0) localAddr := make([]string, 0)
@ -350,7 +351,10 @@ func TestClientReceivedGOAWAY(t *testing.T) {
if err != nil { if err != nil {
t.Fatalf("unexpect connection err: %v", err) t.Fatalf("unexpect connection err: %v", err)
} }
mu.Lock()
localAddr = append(localAddr, conn.LocalAddr().String()) localAddr = append(localAddr, conn.LocalAddr().String())
mu.Unlock()
return return
}) })
if err != nil { if err != nil {