github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-18 04:54:54 +00:00
Code Issues Projects Releases Wiki Activity

DRA Kubelet: optimize GetContainerClaimInfos claim lookup

Browse Source 
Use map for O(1) container claim lookup instead of O(n*m) nested loop.
This commit is contained in:
Ed Bartosh
2026-01-16 11:11:14 +02:00
parent 0a9377b318
commit 1f8bd2ffaa
1 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
pkg/kubelet/cm/dra/manager.go
View File

@@ -721,7 +721,18 @@ func (m *Manager) PodMightNeedToUnprepareResources(uid types.UID) bool {
func (m *Manager) GetContainerClaimInfos(pod *v1.Pod, container *v1.Container) ([]*ClaimInfo, error) {
claimInfos := make([]*ClaimInfo, 0, len(pod.Spec.ResourceClaims))
// Build a map of container claims for O(1) lookup
containerClaimsMap := make(map[string]bool, len(container.Resources.Claims))
for _, claim := range container.Resources.Claims {
containerClaimsMap[claim.Name] = true
}
for i, podResourceClaim := range pod.Spec.ResourceClaims {
// Only process claims that this container actually uses
if !containerClaimsMap[podResourceClaim.Name] {
continue
}
claimName, _, err := resourceclaim.Name(pod, &pod.Spec.ResourceClaims[i])
if err != nil {
// No wrapping, the error is already informative.
@@ -735,23 +746,17 @@ func (m *Manager) GetContainerClaimInfos(pod *v1.Pod, container *v1.Container) (
// Ownership doesn't get checked here, this should have been done before.
for _, claim := range container.Resources.Claims {
if podResourceClaim.Name != claim.Name {
continue
}
err := m.cache.withRLock(func() error {
claimInfo, exists := m.cache.get(*claimName, pod.Namespace)
if !exists {
return fmt.Errorf("unable to get information for ResourceClaim %s", *claimName)
}
claimInfos = append(claimInfos, claimInfo.DeepCopy())
return nil
})
if err != nil {
// No wrapping, this is the error above.
return nil, err
err = m.cache.withRLock(func() error {
claimInfo, exists := m.cache.get(*claimName, pod.Namespace)
if !exists {
return fmt.Errorf("unable to get information for ResourceClaim %s", *claimName)
}
claimInfos = append(claimInfos, claimInfo.DeepCopy())
return nil
})
if err != nil {
// No wrapping, this is the error above.
return nil, err
}
}